Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_: profile name not displayed on the login page for synced device in the fallback flow #5876

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Sep 25, 2024

fixes status-im/status-mobile#21263

Summary

This PR resolves the issue of missing profile names on the login page for synced devices using the fallback flow.

  • Updated the test TestRestoreAccountAndLogin to ensure the account name is not empty.
  • Modified prepareNodeAccount in geth_backend.go to assign the account name from settings if it’s initially empty.

status-mobile PR: status-im/status-mobile#21321

status; ready

@status-im-auto
Copy link
Member

status-im-auto commented Sep 25, 2024

Jenkins Builds

Click to see older builds (15)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b95460e #1 2024-09-25 09:13:52 ~2 min tests-rpc 📄log
✔️ b95460e #1 2024-09-25 09:15:31 ~4 min linux 📦zip
✔️ b95460e #1 2024-09-25 09:15:31 ~4 min ios 📦zip
✔️ b95460e #1 2024-09-25 09:16:33 ~5 min android 📦aar
✔️ b95460e #1 2024-09-25 09:44:14 ~32 min tests 📄log
✔️ e6288fb #2 2024-09-26 07:38:04 ~2 min android 📦aar
✔️ e6288fb #2 2024-09-26 07:38:42 ~2 min tests-rpc 📄log
✔️ e6288fb #2 2024-09-26 07:38:56 ~3 min ios 📦zip
✔️ e6288fb #2 2024-09-26 07:39:49 ~3 min linux 📦zip
✔️ e6288fb #2 2024-09-26 08:09:06 ~33 min tests 📄log
✖️ c3aa4f3 #3 2024-09-27 13:18:27 ~1 min tests 📄log
✔️ c3aa4f3 #3 2024-09-27 13:19:31 ~2 min android 📦aar
✔️ c3aa4f3 #3 2024-09-27 13:19:43 ~2 min linux 📦zip
✔️ c3aa4f3 #3 2024-09-27 13:19:56 ~2 min tests-rpc 📄log
✔️ c3aa4f3 #3 2024-09-27 13:20:49 ~3 min ios 📦zip
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 46b7357 #4 2024-09-27 13:21:06 ~1 min android 📦aar
✔️ 46b7357 #4 2024-09-27 13:21:32 ~1 min tests-rpc 📄log
✔️ 46b7357 #4 2024-09-27 13:21:54 ~1 min linux 📦zip
✔️ 46b7357 #4 2024-09-27 13:23:49 ~2 min ios 📦zip
✔️ 46b7357 #4 2024-09-27 13:50:38 ~31 min tests 📄log
✔️ b397fc0 #5 2024-09-27 14:16:44 ~1 min android 📦aar
✔️ b397fc0 #5 2024-09-27 14:17:51 ~2 min linux 📦zip
✔️ b397fc0 #5 2024-09-27 14:17:59 ~2 min tests-rpc 📄log
✔️ b397fc0 #5 2024-09-27 14:18:28 ~3 min ios 📦zip
✔️ b397fc0 #5 2024-09-27 14:47:59 ~32 min tests 📄log

Copy link
Contributor

@qfrank qfrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Parveshdhull Parveshdhull force-pushed the fix/empty-profile-name-on-login-page branch from b95460e to e6288fb Compare September 26, 2024 07:35
@Parveshdhull Parveshdhull force-pushed the fix/empty-profile-name-on-login-page branch 2 times, most recently from c3aa4f3 to 46b7357 Compare September 27, 2024 13:18
@Parveshdhull Parveshdhull changed the title fix profile name not displayed on the login page for synced device in the fallback flow fix: profile name not displayed on the login page for synced device in the fallback flow Sep 27, 2024
@Parveshdhull Parveshdhull changed the title fix: profile name not displayed on the login page for synced device in the fallback flow fix_: profile name not displayed on the login page for synced device in the fallback flow Sep 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@7a23ac5). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #5876   +/-   ##
==========================================
  Coverage           ?   46.06%           
==========================================
  Files              ?      888           
  Lines              ?   157374           
  Branches           ?        0           
==========================================
  Hits               ?    72502           
  Misses             ?    76568           
  Partials           ?     8304           
Flag Coverage Δ
functional 11.60% <0.00%> (?)
unit 45.64% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/geth_backend.go 54.60% <100.00%> (ø)

@Parveshdhull Parveshdhull force-pushed the fix/empty-profile-name-on-login-page branch from 46b7357 to b397fc0 Compare September 27, 2024 14:15
@Parveshdhull Parveshdhull merged commit 42f715f into develop Sep 27, 2024
12 checks passed
@Parveshdhull Parveshdhull deleted the fix/empty-profile-name-on-login-page branch September 27, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile name not displayed on the login page for synced device in falback flow
6 participants