fix(sync)_: Improve EnableInstallationAndSync to include installation in MessengerResponse #5869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (5)
|
jrainville
approved these changes
Sep 24, 2024
not sure if desktop exists the same issue as mobile, if desktop does not need updated installation info within MessengerResponse returned from EnableInstallationAndSync, that's okay. @jrainville |
ilmotta
reviewed
Sep 26, 2024
qfrank
force-pushed
the
fix/sync_fallback_response_installation_update
branch
from
5e7284f to
abfa2eb
Compare
ilmotta
approved these changes
Sep 26, 2024
✔️ status-go/prs/android/PR-5869#2 🔹 ~2 min 43 sec 🔹 abfa2eb 🔹 📦 android package |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #5869 +/- ##
==========================================
Coverage ? 46.06%
==========================================
Files ? 884
Lines ? 157316
Branches ? 0
==========================================
Hits ? 72462
Misses ? 76535
Partials ? 8319
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ionV2 - Refactor EnableInstallationAndSync for better error handling and response merging - Add new EnableInstallationV2 method returning the installation - Update tests to check for installation in response - Deprecate old EnableInstallation method
qfrank
force-pushed
the
fix/sync_fallback_response_installation_update
branch
from
abfa2eb to
6640204
Compare
|
close this and use PR 5888 instead cc @Parveshdhull |
✔️ status-go/prs/tests/PR-5869#3 🔹 ~31 min 🔹 6640204 🔹 📦 tests package |
igor-sirotin
deleted the
fix/sync_fallback_response_installation_update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
fix relate comment
status: ready