fix(manager)_: make sure to re-add revealed accounts in the response #5867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (5)
|
3 tasks
jrainville
force-pushed
the
fix/no-revealed-accounts-in-response
branch
from
353dd36 to
0b78473
Compare
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
igor-sirotin
approved these changes
Sep 27, 2024
| @@ -922,6 +922,7 @@ func (s *MessengerCommunitiesSuite) TestRequestAccess() { | |||
| response, err = s.bob.AcceptRequestToJoinCommunity(acceptRequestToJoin) | |||
| s.Require().NoError(err) | |||
| s.Require().NotNil(response) | |||
| s.Require().Len(response.RequestsToJoinCommunity()[0].RevealedAccounts, 1) | |||
There was a problem hiding this comment.
Better to prevent panics in tests as much as possible
Suggested change
| s.Require().Len(response.RequestsToJoinCommunity()[0].RevealedAccounts, 1) | |
| s.Require().NotEmpty(response.RequestsToJoinCommunity()) | |
| s.Require().Len(response.RequestsToJoinCommunity()[0].RevealedAccounts, 1) |
We remove the shared accounts to send normal admins to not leak the addresses, however, that was a destructive action that also removed them from the `requestToJoin` param, which is reused later in the code, so it created an unwanted side effect. The side effect is now erased.
jrainville
force-pushed
the
fix/no-revealed-accounts-in-response
branch
from
0b78473 to
8cafbcb
Compare
|
@osmaczko reminder to review please |
osmaczko
approved these changes
Oct 1, 2024
| @@ -4897,18 +4897,22 @@ func (m *Manager) ShareRequestsToJoinWithPrivilegedMembers(community *Community, | |||
| return nil | |||
| } | |||
|
|
|||
| func (m *Manager) shareAcceptedRequestToJoinWithPrivilegedMembers(community *Community, requestsToJoin *RequestToJoin) error { | |||
| pk, err := common.HexToPubkey(requestsToJoin.PublicKey) | |||
| func (m *Manager) shareAcceptedRequestToJoinWithPrivilegedMembers(community *Community, requestToJoin *RequestToJoin) error { | |||
There was a problem hiding this comment.
Suggested change
| func (m *Manager) shareAcceptedRequestToJoinWithPrivilegedMembers(community *Community, requestToJoin *RequestToJoin) error { | |
| func (m *Manager) shareAcceptedRequestToJoinWithPrivilegedMembers(community *Community, requestToJoin *const RequestToJoin) error { |
@ google can you please introduce this concept?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove the shared accounts to send normal admins to not leak the addresses, however, that was a destructive action that also removed them from the
requestToJoinparam, which is reused later in the code, so it created an unwanted side effect. The side effect is now erased.