fix_: ignore log partial API request #5865

qfrank · 2024-09-23T13:58:11Z

Major changes:

Added extra sensitive fields in regex.
Added some new V2 APIs and removed logging for the old ones:

VerifyDatabasePassword -> VerifyDatabasePasswordV2
MigrateKeyStoreDir -> MigrateKeyStoreDirV2
DeleteImportedKey -> DeleteImportedKeyV2
SignTypedData -> SignTypedDataV2

Removed the following sensitive APIs for logging as a quick fix, we can create a separate pull request to create V2 APIs for them later if needed:

SignTypedDataV4 
SendTransactionWithChainID 
SendTransaction 
ValidateMnemonic
ExportUnencryptedDatabase
ImportUnencryptedDatabase
ChangeDatabasePassword
ConvertToKeycardAccount
ConvertToRegularAccount

Relate comment

Please review the code by commit , tx

status-im-auto · 2024-09-23T13:59:46Z

Jenkins Builds

Click to see older builds (50)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✖️	`195e460`	#1	2024-09-23 13:59:45	~1 min	`tests`	📄`log`
✔️	`195e460`	#1	2024-09-23 14:01:13	~2 min	`tests-rpc`	📄`log`
✔️	`195e460`	#1	2024-09-23 14:02:25	~3 min	`linux`	📦`zip`
✔️	`195e460`	#1	2024-09-23 14:03:31	~5 min	`ios`	📦`zip`
✔️	`195e460`	#1	2024-09-23 14:03:42	~5 min	`android`	📦`aar`

✔️	`c4158e1`	#2	2024-09-23 14:02:38	~1 min	`tests-rpc`	📄`log`
✔️	`c4158e1`	#2	2024-09-23 14:04:40	~2 min	`linux`	📦`zip`
✔️	`c4158e1`	#2	2024-09-23 14:05:26	~1 min	`android`	📦`aar`
✔️	`c4158e1`	#2	2024-09-23 14:06:56	~3 min	`ios`	📦`zip`
✔️	`c4158e1`	#2	2024-09-23 14:32:22	~32 min	`tests`	📄`log`

✔️	`42eba58`	#3	2024-09-23 14:08:14	~2 min	`android`	📦`aar`
✔️	`42eba58`	#3	2024-09-23 14:08:27	~2 min	`tests-rpc`	📄`log`
✔️	`42eba58`	#3	2024-09-23 14:10:25	~4 min	`linux`	📦`zip`
✔️	`42eba58`	#3	2024-09-23 14:13:49	~6 min	`ios`	📦`zip`
✔️	`42eba58`	#3	2024-09-23 15:04:58	~32 min	`tests`	📄`log`

✔️	`f8770db`	#4	2024-09-24 02:40:20	~2 min	`tests-rpc`	📄`log`
✔️	`f8770db`	#4	2024-09-24 02:40:29	~2 min	`android`	📦`aar`
✔️	`f8770db`	#4	2024-09-24 02:40:42	~2 min	`linux`	📦`zip`
✔️	`f8770db`	#4	2024-09-24 02:43:36	~5 min	`ios`	📦`zip`
✔️	`f8770db`	#4	2024-09-24 03:09:50	~31 min	`tests`	📄`log`

✔️	`b61bebb`	#5	2024-09-24 12:47:01	~1 min	`android`	📦`aar`
✔️	`b61bebb`	#5	2024-09-24 12:47:31	~2 min	`linux`	📦`zip`
✔️	`b61bebb`	#5	2024-09-24 12:48:16	~2 min	`tests-rpc`	📄`log`
✔️	`b61bebb`	#5	2024-09-24 12:49:13	~3 min	`ios`	📦`zip`
✔️	`b61bebb`	#5	2024-09-24 13:16:57	~31 min	`tests`	📄`log`

❌	`c1bd588`	#6	2024-09-24 14:09:38	~41 sec	`android`	📄`log`
❌	`c1bd588`	#6	2024-09-24 14:10:05	~1 min	`ios`	📄`log`
❌	`c1bd588`	#6	2024-09-24 14:10:40	~1 min	`linux`	📄`log`
✖️	`c1bd588`	#6	2024-09-24 14:11:25	~2 min	`tests`	📄`log`
✔️	`c1bd588`	#6	2024-09-24 14:11:55	~2 min	`tests-rpc`	📄`log`

❌	`81e5ae5`	#7	2024-09-24 14:25:34	~52 sec	`ios`	📄`log`
❌	`81e5ae5`	#7	2024-09-24 14:27:47	~3 min	`android`	📄`log`
✖️	`81e5ae5`	#7	2024-09-24 14:29:18	~4 min	`tests`	📄`log`
❌	`81e5ae5`	#7	2024-09-24 14:29:23	~4 min	`linux`	📄`log`
✔️	`81e5ae5`	#7	2024-09-24 14:30:06	~5 min	`tests-rpc`	📄`log`

❌	`4b1cfde`	#8	2024-09-24 14:43:30	~43 sec	`ios`	📄`log`
❌	`4b1cfde`	#8	2024-09-24 14:43:41	~47 sec	`linux`	📄`log`
❌	`4b1cfde`	#8	2024-09-24 14:44:13	~1 min	`android`	📄`log`
✔️	`4b1cfde`	#8	2024-09-24 14:44:55	~2 min	`tests-rpc`	📄`log`
✖️	`4b1cfde`	#8	2024-09-24 14:46:09	~3 min	`tests`	📄`log`

✖️	`3a81367`	#9	2024-09-24 15:01:31	~1 min	`tests`	📄`log`
✔️	`3a81367`	#9	2024-09-24 15:02:25	~2 min	`tests-rpc`	📄`log`
✔️	`3a81367`	#9	2024-09-24 15:03:33	~3 min	`android`	📦`aar`
✔️	`3a81367`	#9	2024-09-24 15:03:47	~3 min	`ios`	📦`zip`
✔️	`3a81367`	#9	2024-09-24 15:04:02	~3 min	`linux`	📦`zip`

✔️	`dd9dded`	#10	2024-09-24 15:05:32	~1 min	`android`	📦`aar`
✔️	`dd9dded`	#10	2024-09-24 15:05:42	~2 min	`tests-rpc`	📄`log`
✔️	`dd9dded`	#10	2024-09-24 15:06:06	~1 min	`linux`	📦`zip`
✖️	`dd9dded`	#10	2024-09-24 15:06:06	~2 min	`tests`	📄`log`
✔️	`dd9dded`	#10	2024-09-24 15:07:24	~3 min	`ios`	📦`zip`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✖️	`e364908`	#11	2024-09-25 00:25:13	~14 sec	`tests-rpc`	📄`log`
✔️	`e364908`	#11	2024-09-25 00:26:58	~2 min	`android`	📦`aar`
✔️	`e364908`	#11	2024-09-25 00:27:20	~2 min	`linux`	📦`zip`
✔️	`e364908`	#11	2024-09-25 00:28:29	~3 min	`ios`	📦`zip`
✔️	`e364908`	#11	2024-09-25 00:56:23	~31 min	`tests`	📄`log`

✔️	`7cf2c9f`	#12	2024-09-27 02:05:26	~2 min	`android`	📦`aar`
✔️	`7cf2c9f`	#12	2024-09-27 02:05:42	~2 min	`tests-rpc`	📄`log`
✔️	`7cf2c9f`	#12	2024-09-27 02:05:50	~2 min	`linux`	📦`zip`
✔️	`7cf2c9f`	#12	2024-09-27 02:07:35	~4 min	`ios`	📦`zip`
✔️	`7cf2c9f`	#12	2024-09-27 02:34:44	~31 min	`tests`	📄`log`

qfrank · 2024-09-23T14:01:48Z

cc @churik

mobile/status.go

mobile/status_request_log.go

protocol/requests/delete_imported_key.go

igor-sirotin

Thank you for the changes and the tests 👍

codecov-commenter · 2024-09-25T00:56:27Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
2798	1	2797	29

View the top 1 failed tests by shortest run time

github.com/status-im/status-go/protocol TestMessengerCommunitiesSuite

Stack Traces | 324s run time

=== RUN   TestMessengerCommunitiesSuite&#xA;--- FAIL: TestMessengerCommunitiesSuite (324.06s)&#xA;

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

qfrank requested review from igor-sirotin and osmaczko September 23, 2024 13:58

qfrank self-assigned this Sep 23, 2024

qfrank force-pushed the fix/LogVerifyDatabasePassword branch from 195e460 to c4158e1 Compare September 23, 2024 13:59

qfrank force-pushed the fix/LogVerifyDatabasePassword branch from 42eba58 to f8770db Compare September 24, 2024 02:37

qfrank changed the title ~~fix: Add VerifyDatabasePasswordV2 and deprecate VerifyDatabasePassword~~ fix: ignore log partial API request Sep 24, 2024

qfrank mentioned this pull request Sep 24, 2024

fix_: ignore log partial API request status-im/status-mobile#21312

Merged

igor-sirotin reviewed Sep 24, 2024

View reviewed changes

mobile/status.go Outdated Show resolved Hide resolved

mobile/status.go Outdated Show resolved Hide resolved

mobile/status_request_log.go Outdated Show resolved Hide resolved

protocol/requests/delete_imported_key.go Outdated Show resolved Hide resolved

qfrank force-pushed the fix/LogVerifyDatabasePassword branch 5 times, most recently from 3a81367 to dd9dded Compare September 24, 2024 15:03

igor-sirotin approved these changes Sep 24, 2024

View reviewed changes

qfrank force-pushed the fix/LogVerifyDatabasePassword branch from dd9dded to e364908 Compare September 25, 2024 00:24

qfrank requested a review from ilmotta September 25, 2024 06:56

qfrank added 3 commits September 27, 2024 10:00

fix_: ignore log partial sensitive API request

6682365

chore_: use validator

e476aae

chore_: rebase

7cf2c9f

qfrank force-pushed the fix/LogVerifyDatabasePassword branch from e364908 to 7cf2c9f Compare September 27, 2024 02:02

qfrank requested a review from a team September 27, 2024 03:13

osmaczko approved these changes Sep 27, 2024

View reviewed changes

igor-sirotin changed the title ~~fix: ignore log partial API request~~ fix_: ignore log partial API request Sep 27, 2024

igor-sirotin merged commit 7a23ac5 into develop Sep 27, 2024
11 of 13 checks passed

igor-sirotin deleted the fix/LogVerifyDatabasePassword branch September 27, 2024 10:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix_: ignore log partial API request #5865

fix_: ignore log partial API request #5865

qfrank commented Sep 23, 2024 •

edited

Loading

status-im-auto commented Sep 23, 2024 •

edited

Loading

qfrank commented Sep 23, 2024

igor-sirotin left a comment

codecov-commenter commented Sep 25, 2024 •

edited

Loading

fix_: ignore log partial API request #5865

fix_: ignore log partial API request #5865

Conversation

qfrank commented Sep 23, 2024 • edited Loading

status-im-auto commented Sep 23, 2024 • edited Loading

Jenkins Builds

qfrank commented Sep 23, 2024

igor-sirotin left a comment

Choose a reason for hiding this comment

codecov-commenter commented Sep 25, 2024 • edited Loading

❌ 1 Tests Failed:

qfrank commented Sep 23, 2024 •

edited

Loading

status-im-auto commented Sep 23, 2024 •

edited

Loading

codecov-commenter commented Sep 25, 2024 •

edited

Loading