fix(reactions): fix old reactions not being migrated #19280

jrainville · 2025-11-16T21:19:05Z

What does the PR do

Issue by @sunleos , if you migrate an account from 2.35 or lower to master, the old emojis reactions would show blank.

The solution was to add a migration on the backend.
Se the PR here: status-im/status-go#7110

Affected areas

status-go migration

Architecture compliance

I am familiar with the application architecture and agreed good practices.
My PR is consistent with this document: QML Architecture Guidelines

Screencapture of the functionality

Impact on end user

Fixes the issue

How to test

Migrate an old account that had emoji reactions

Risk

Low

status-im-auto · 2025-11-16T21:27:42Z

Jenkins Builds

Click to see older builds (60)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`c99f76c`	#1	2025-11-16 21:27:41	~8 min	`tests/nim`	📄`log`
✔️	`c99f76c`	#1	2025-11-16 21:28:57	~9 min	`android/arm64`	🤖`apk` 📲
❌	`c99f76c`	#1	2025-11-16 21:29:39	~10 min	`macos/aarch64-nwaku`	📄`log`
✔️	`c99f76c`	#1	2025-11-16 21:33:02	~13 min	`macos/aarch64`	🍎`dmg`
✔️	`c99f76c`	#1	2025-11-16 21:33:13	~13 min	`ios/aarch64`	📱`ipa`
✔️	`c99f76c`	#1	2025-11-16 21:34:21	~14 min	`tests/ui`	📄`log`
✔️	`c99f76c`	#1	2025-11-16 21:36:14	~16 min	`linux/x86_64`	📦`tgz`
✔️	`c99f76c`	#1	2025-11-16 21:41:54	~22 min	`linux/x86_64-nwaku`	📦`tgz`
✔️	`c99f76c`	#1	2025-11-16 21:49:04	~29 min	`windows/x86_64`	💿`exe`
✔️	`c99f76c`	pr19280	2025-11-16 21:52:35	~16 min	`tests/e2e`	📊`rpt`
✖️	`c99f76c`	PR19280	2025-11-16 22:01:48	~12 min	`tests/e2e-windows`	📊`rpt`

✔️	b9202a74	#2	2025-11-17 17:26:54	~11 min	`android/arm64`	🤖`apk` 📲

❌	4af2a1ed	#4	2025-11-18 13:34:49	~6 min	`android/arm64`	📄`log`

✔️	`2815de8`	#3	2025-11-18 13:35:37	~7 min	`tests/nim`	📄`log`
✔️	`2815de8`	#3	2025-11-18 13:41:57	~13 min	`tests/ui`	📄`log`
✔️	`2815de8`	#3	2025-11-18 13:43:36	~15 min	`macos/aarch64`	🍎`dmg`
✔️	`2815de8`	#3	2025-11-18 13:43:52	~15 min	`ios/aarch64`	📱`ipa`
✔️	`2815de8`	#3	2025-11-18 13:44:35	~16 min	`macos/aarch64-nwaku`	🍎`dmg`
✔️	`2815de8`	#3	2025-11-18 13:46:32	~18 min	`linux/x86_64`	📦`tgz`
✔️	`2815de8`	#3	2025-11-18 13:52:51	~24 min	`linux/x86_64-nwaku`	📦`tgz`
✔️	`2815de8`	#3	2025-11-18 14:03:32	~35 min	`windows/x86_64`	💿`exe`
✔️	`2815de8`	pr19280	2025-11-18 14:06:05	~19 min	`tests/e2e`	📊`rpt`
✖️	`2815de8`	PR19280	2025-11-18 14:29:54	~26 min	`tests/e2e-windows`	📊`rpt`

❌	28e667e8	#5	2025-11-18 14:05:59	~5 min	`android/arm64`	📄`log`

❌	52668586	#6	2025-11-18 14:41:01	~5 min	`android/arm64`	📄`log`

❌	`fb31e5c`	#4	2025-11-18 16:24:19	~6 min	`macos/aarch64-nwaku`	📄`log`
✔️	`fb31e5c`	#4	2025-11-18 16:26:20	~8 min	`tests/nim`	📄`log`
✔️	`fb31e5c`	#8	2025-11-18 16:30:44	~13 min	`android/arm64`	🤖`apk` 📲
✔️	`fb31e5c`	#4	2025-11-18 16:31:17	~13 min	`ios/aarch64`	📱`ipa`
✔️	`fb31e5c`	#4	2025-11-18 16:31:40	~14 min	`macos/aarch64`	🍎`dmg`
✔️	`fb31e5c`	#4	2025-11-18 16:32:35	~15 min	`linux/x86_64-nwaku`	📦`tgz`
✔️	`fb31e5c`	#4	2025-11-18 16:33:51	~16 min	`tests/ui`	📄`log`
✔️	`fb31e5c`	#4	2025-11-18 16:34:03	~16 min	`linux/x86_64`	📦`tgz`
✔️	`fb31e5c`	pr19280	2025-11-18 16:50:16	~16 min	`tests/e2e`	📊`rpt`
✔️	`fb31e5c`	#4	2025-11-18 16:55:28	~37 min	`windows/x86_64`	💿`exe`
✖️	`fb31e5c`	PR19280	2025-11-18 17:15:41	~20 min	`tests/e2e-windows`	📊`rpt`
✔️	`fb31e5c`	#5	2025-11-18 17:15:59	~18 min	`macos/aarch64-nwaku`	🍎`dmg`

❌	`8bc2319`	#6	2025-11-19 10:37:02	~6 min	`macos/aarch64-nwaku`	📄`log`
✔️	`8bc2319`	#5	2025-11-19 10:37:15	~6 min	`tests/nim`	📄`log`
✔️	`8bc2319`	#9	2025-11-19 10:40:13	~9 min	`android/arm64`	🤖`apk` 📲
✔️	`8bc2319`	#5	2025-11-19 10:43:16	~12 min	`macos/aarch64`	🍎`dmg`
✔️	`8bc2319`	#5	2025-11-19 10:43:19	~12 min	`ios/aarch64`	📱`ipa`
✔️	`8bc2319`	#5	2025-11-19 10:44:04	~13 min	`tests/ui`	📄`log`
✔️	`8bc2319`	#5	2025-11-19 10:46:30	~15 min	`linux/x86_64-nwaku`	📦`tgz`
✔️	`8bc2319`	#5	2025-11-19 10:46:49	~15 min	`linux/x86_64`	📦`tgz`
✔️	`8bc2319`	pr19280	2025-11-19 11:02:17	~15 min	`tests/e2e`	📊`rpt`
✔️	`8bc2319`	#5	2025-11-19 11:06:28	~35 min	`windows/x86_64`	💿`exe`
✖️	`8bc2319`	PR19280	2025-11-19 11:34:43	~28 min	`tests/e2e-windows`	📊`rpt`

✔️	cb42e22a	#10	2025-11-19 17:27:57	~12 min	`android/arm64`	🤖`apk` 📲

❌	`5f45d68`	#11	2025-11-19 22:26:38	~6 min	`android/arm64`	📄`log`
✔️	`5f45d68`	#6	2025-11-19 22:27:19	~7 min	`tests/nim`	📄`log`
✔️	`5f45d68`	#6	2025-11-19 22:33:10	~13 min	`ios/aarch64`	📱`ipa`
✔️	`5f45d68`	#7	2025-11-19 22:33:16	~13 min	`macos/aarch64-nwaku`	🍎`dmg`
✔️	`5f45d68`	#6	2025-11-19 22:33:23	~13 min	`macos/aarch64`	🍎`dmg`
✔️	`5f45d68`	#6	2025-11-19 22:36:16	~16 min	`tests/ui`	📄`log`
✔️	`5f45d68`	#6	2025-11-19 22:36:39	~16 min	`linux/x86_64`	📦`tgz`
✔️	`5f45d68`	#6	2025-11-19 22:36:46	~16 min	`linux/x86_64-nwaku`	📦`tgz`
✔️	`5f45d68`	pr19280	2025-11-19 22:52:40	~15 min	`tests/e2e`	📊`rpt`
✔️	`5f45d68`	#6	2025-11-19 22:53:03	~32 min	`windows/x86_64`	💿`exe`
✖️	`5f45d68`	PR19280	2025-11-19 23:14:08	~20 min	`tests/e2e-windows`	📊`rpt`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`e56b9e1`	#8	2025-11-19 23:34:29	~5 min	`macos/aarch64-nwaku`	📄`log`
❌	`e56b9e1`	#12	2025-11-19 23:34:45	~6 min	`android/arm64`	📄`log`
✔️	`e56b9e1`	#7	2025-11-19 23:35:59	~7 min	`tests/nim`	📄`log`
✔️	`e56b9e1`	#7	2025-11-19 23:41:20	~12 min	`ios/aarch64`	📱`ipa`
✔️	`e56b9e1`	#7	2025-11-19 23:42:57	~14 min	`tests/ui`	📄`log`
✔️	`e56b9e1`	#7	2025-11-19 23:44:29	~15 min	`linux/x86_64`	📦`tgz`
✔️	`e56b9e1`	#7	2025-11-19 23:46:19	~17 min	`linux/x86_64-nwaku`	📦`tgz`
✔️	`e56b9e1`	pr19280	2025-11-20 00:00:18	~15 min	`tests/e2e`	📊`rpt`
✔️	`e56b9e1`	#7	2025-11-20 00:05:57	~37 min	`windows/x86_64`	💿`exe`
✖️	`e56b9e1`	PR19280	2025-11-20 00:32:07	~26 min	`tests/e2e-windows`	📊`rpt`

❌	`4e03d0f`	#9	2025-11-20 19:06:17	~5 min	`macos/aarch64-nwaku`	📄`log`
✔️	`4e03d0f`	#8	2025-11-20 19:06:46	~6 min	`tests/nim`	📄`log`
✔️	`4e03d0f`	#8	2025-11-20 19:12:19	~11 min	`macos/aarch64`	🍎`dmg`
✔️	`4e03d0f`	#8	2025-11-20 19:12:37	~12 min	`ios/aarch64`	📱`ipa`
✔️	`4e03d0f`	#8	2025-11-20 19:13:45	~13 min	`tests/ui`	📄`log`
✔️	`4e03d0f`	#8	2025-11-20 19:16:16	~15 min	`linux/x86_64`	📦`tgz`
✔️	`4e03d0f`	#8	2025-11-20 19:16:20	~15 min	`linux/x86_64-nwaku`	📦`tgz`
✔️	`4e03d0f`	pr19280	2025-11-20 19:31:59	~15 min	`tests/e2e`	📊`rpt`
✔️	`4e03d0f`	#8	2025-11-20 19:33:35	~32 min	`windows/x86_64`	💿`exe`
✖️	`4e03d0f`	PR19280	2025-11-20 20:01:10	~27 min	`tests/e2e-windows`	📊`rpt`

caybro · 2025-11-18T13:19:54Z

I'll rebase the PR

caybro · 2025-11-18T13:21:27Z

I'll rebase the PR

~~Done~~

caybro · 2025-11-18T13:28:36Z

Rebased to latest develop (which contains the vendoring changes as well); hope that's ok for the 2.36 release branch too @igor-sirotin @osmaczko

igor-sirotin · 2025-11-18T13:41:29Z

Rebased to latest develop (which contains the vendoring changes as well); hope that's ok for the 2.36 release branch too

Yes it should be good. It only changes how we get dependencies, but not the dependencies/code itself.

caybro · 2025-11-18T14:01:45Z

Rebased to latest develop (which contains the vendoring changes as well); hope that's ok for the 2.36 release branch too

Yes it should be good. It only changes how we get dependencies, but not the dependencies/code itself.

I restarted the build but it seems like it fails on Android while building status-go :/

caybro · 2025-11-18T14:28:46Z

Yup, it failed to build on Android :( Halp needed @alexjba @igor-sirotin

This one is suspicious:

[2025-11-18T14:05:45.310Z]  "/opt/android-sdk/ndk/27.2.12479018/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-18" -cc1as -triple aarch64-unknown-linux-android28 -filetype obj -main-file-name gcc_amd64.S -target-cpu generic -target-feature +neon -target-feature +v8a -target-feature +fix-cortex-a53-835769 -I /usr/local/go/src/runtime/cgo -I $WORK/b081/ -fdebug-compilation-dir=/usr/local/go/src/runtime/cgo -dwarf-debug-producer "Android (12470979, +pgo, +bolt, +lto, +mlgo, based on r522817c) clang version 18.0.3 (https://android.googlesource.com/toolchain/llvm-project d8003a456d14a3deb8054cdaa529ffbf02d9b262)" -I /usr/local/go/src/runtime/cgo -I $WORK/b081/ -debug-info-kind=constructor -dwarf-version=4 -mrelocation-model pic -fembed-bitcode=all -object-file-name=/home/jenkins/workspace/status-desktop-android/5@tmp/go-build1131295384/b081/_x014.o -o $WORK/b081/_x014.o /tmp/gcc_amd64-2a6236.s

it's trying to build gcc_amd64.S assembly on aarch64

igor-sirotin · 2025-11-18T14:31:27Z

I restarted the build but it seems like it fails on Android while building status-go :/

@caybro Actually, we should have not rebased it to latest develop.
There is a release branch for 2.36 — release/10.31.x. And it does not include latest vendor changes

UPD: Or we don't want this in release?

caybro · 2025-11-18T14:33:01Z

I restarted the build but it seems like it fails on Android while building status-go :/

@caybro Actually, we should have not rebased it to latest develop. There is a release branch for 2.36 — release/10.31.x. And it does not include latest vendor changes

UPD: Or we don't want this in release?

I think we definitely want this PR in the release

caybro · 2025-11-18T14:35:26Z

I think the easiest would be to backport status-im/status-go#7110 into the release/10.31.x, and then update this PR

igor-sirotin · 2025-11-18T14:36:52Z

I'm not sure wtf is going on with Android build, not sure how this could have been caused. I tested the changes in desktop before merging.

Yeah, cherry-pick to status-go release and then base this PR on release makes the most sense to me now 👍

caybro · 2025-11-18T15:01:49Z

I'm not sure wtf is going on with Android build, not sure how this could have been caused. I tested the changes in desktop before merging.

Yeah, cherry-pick to status-go release and then base this PR on release makes the most sense to me now 👍

Can you pls take care of this 🙏

igor-sirotin · 2025-11-18T16:17:43Z

Can you pls take care of this 🙏

done, let's see if it builds
here's status-go PR: status-im/status-go#7119

caybro · 2025-11-18T16:52:26Z

Can you pls take care of this 🙏

done, let's see if it builds here's status-go PR: status-im/status-go#7119

It seems it worked :) Now I noticed you're already targetting the release branch... let's make sure we don't overwrite it later on @alaibe, or just merge this one after the release branch update? 🤔

igor-sirotin · 2025-11-18T17:00:42Z

It seems it worked :) Now I noticed you're already targetting the release branch... let's make sure we don't overwrite it later on @alaibe, or just merge this one after the release branch update? 🤔

Yes, targeting release branch directly. Not sure I got what order you mean?

noeliaSD · 2025-11-19T09:50:38Z

Hey @caybro @igor-sirotin we will cut the release again today from master bc all the prs intregrated yesterday need to me in the release so that it's easier to start again. Please merge this pr directly to master

igor-sirotin · 2025-11-19T10:30:14Z

we will cut the release again today from master bc all the prs intregrated yesterday need to me in the release so that it's easier to start again. Please merge this pr directly to master

@noeliaSD we're keeping the release/10.31.x branch of status-go, right?

igor-sirotin · 2025-11-20T19:00:35Z

Trying to point directly to status-go 1f18d4d326537e1da90faac6b29dee6aa3bdc6d1

igor-sirotin · 2025-11-21T16:03:29Z

status-im/status-go#7110 was already merged in to master as part of #19299

jrainville requested review from a team as code owners November 16, 2025 21:19

jrainville requested review from igor-sirotin and osmaczko and removed request for a team November 16, 2025 21:19

caybro approved these changes Nov 17, 2025

View reviewed changes

igor-sirotin approved these changes Nov 17, 2025

View reviewed changes

caybro force-pushed the fix/old-emoji-not-showing branch from c99f76c to 669ba53 Compare November 18, 2025 13:21

caybro force-pushed the fix/old-emoji-not-showing branch from 669ba53 to 2815de8 Compare November 18, 2025 13:27

osmaczko approved these changes Nov 18, 2025

View reviewed changes

sunleos added this to the 2.36.0 milestone Nov 18, 2025

sunleos added this to Status Desktop/Mobile Board Nov 18, 2025

igor-sirotin force-pushed the fix/old-emoji-not-showing branch from 2815de8 to fb31e5c Compare November 18, 2025 16:17

igor-sirotin changed the base branch from master to release/2.36.x November 18, 2025 16:17

igor-sirotin force-pushed the fix/old-emoji-not-showing branch from fb31e5c to 8bc2319 Compare November 19, 2025 10:30

igor-sirotin requested review from a team, alexjba, micieslak and noeliaSD as code owners November 19, 2025 10:30

igor-sirotin requested review from vkjr and removed request for a team November 19, 2025 10:30

igor-sirotin changed the base branch from release/2.36.x to master November 19, 2025 10:30

jrainville and others added 2 commits November 19, 2025 22:19

fix(reactions): fix old reactions not being migrated

25577be

chore: bump status-go

5f45d68

igor-sirotin force-pushed the fix/old-emoji-not-showing branch from 8bc2319 to 5f45d68 Compare November 19, 2025 22:19

fix: force some go flags

e56b9e1

igor-sirotin requested a review from a team as a code owner November 19, 2025 23:28

vkjr approved these changes Nov 20, 2025

View reviewed changes

chore: status-go 1f18d4d326537e1da90faac6b29dee6aa3bdc6d1

4e03d0f

igor-sirotin closed this Nov 21, 2025

github-project-automation bot moved this to Done in Status Desktop/Mobile Board Nov 21, 2025

fix(reactions): fix old reactions not being migrated #19280

fix(reactions): fix old reactions not being migrated #19280

Uh oh!

Conversation

jrainville commented Nov 16, 2025

What does the PR do

Affected areas

Architecture compliance

Screencapture of the functionality

Impact on end user

How to test

Risk

Uh oh!

status-im-auto commented Nov 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jenkins Builds

Uh oh!

caybro commented Nov 18, 2025

Uh oh!

caybro commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

caybro commented Nov 18, 2025

Uh oh!

igor-sirotin commented Nov 18, 2025

Uh oh!

caybro commented Nov 18, 2025

Uh oh!

caybro commented Nov 18, 2025

Uh oh!

igor-sirotin commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

caybro commented Nov 18, 2025

Uh oh!

caybro commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

igor-sirotin commented Nov 18, 2025

Uh oh!

caybro commented Nov 18, 2025

Uh oh!

igor-sirotin commented Nov 18, 2025

Uh oh!

caybro commented Nov 18, 2025

Uh oh!

igor-sirotin commented Nov 18, 2025

Uh oh!

noeliaSD commented Nov 19, 2025

Uh oh!

igor-sirotin commented Nov 19, 2025

Uh oh!

igor-sirotin commented Nov 20, 2025

Uh oh!

igor-sirotin commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

status-im-auto commented Nov 16, 2025 •

edited

Loading

caybro commented Nov 18, 2025 •

edited

Loading

igor-sirotin commented Nov 18, 2025 •

edited

Loading

caybro commented Nov 18, 2025 •

edited

Loading