-
Notifications
You must be signed in to change notification settings - Fork 86
[Mobile]: Wallet headers responsive layout #18945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (23)
|
noeliaSD
approved these changes
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added 2 minor comments.
It looks really nice in both screen sizes. I like how you used the LayoutItemProxy
here! LGTM!
ec7ee55
to
8f2798b
Compare
caybro
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice work!
8f2798b
to
90c0a3e
Compare
- SavedAddresses: list view made scrollable - RightTabBaseView - LayoutItemProxy as a content holder - RightTabView, SavedAddressesView - minor cleanup Closes: #18932
90c0a3e
to
da056c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
WalletHeader
with two specialized headers:WalletAccountHeader
- for accounts and all accounts viewWalletSavedAddressesHeader
- simple header for saved addresses viewSavedAddresses
's layout fixed - proper scrolling and no unrolled list viewDappsComboBox
- adaptive popup positionHeaderButton
removedCloses: #18932
Closes: #18190
Affected areas
WalletHeader
,WalletLayout
,RightTabView
,RightTabBaseView
and related componentsArchitecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Impact on end user
Medium
How to test
Interact with wallet header