Skip to content

Conversation

micieslak
Copy link
Member

@micieslak micieslak commented Oct 2, 2025

What does the PR do

  • Adapts Wallet's account / all accounts / saved addresses headers to the new responsive layout proposal: Figma
  • Replaces old all-in WalletHeader with two specialized headers:
    • WalletAccountHeader - for accounts and all accounts view
    • WalletSavedAddressesHeader - simple header for saved addresses view
  • Makes header components pure-UI, with non-UI logic externalized
  • SavedAddresses's layout fixed - proper scrolling and no unrolled list view
  • DappsComboBox - adaptive popup position
  • Old, unused HeaderButton removed

Closes: #18932
Closes: #18190

Affected areas

WalletHeader, WalletLayout, RightTabView, RightTabBaseView and related components

Architecture compliance

Screencapture of the functionality

Screenshot from 2025-10-02 12-36-36 Screenshot from 2025-10-02 12-36-20 Screenshot from 2025-10-02 12-35-46 Screenshot from 2025-10-02 12-37-53 Screenshot from 2025-10-02 12-37-24

Impact on end user

Medium

How to test

Interact with wallet header

@micieslak micieslak requested review from a team, alexjba, caybro and noeliaSD as code owners October 2, 2025 10:56
@micieslak micieslak requested review from Khushboo-dev-cpp and removed request for a team October 2, 2025 10:56
@status-im-auto
Copy link
Member

status-im-auto commented Oct 2, 2025

Jenkins Builds

Click to see older builds (23)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 34bcd1c #1 2025-10-02 11:06:16 ~9 min android/arm64 🤖apk 📲
✔️ 34bcd1c #1 2025-10-02 11:06:29 ~9 min ios/aarch64 📦pkg
✔️ 34bcd1c #1 2025-10-02 11:08:48 ~12 min tests/nim 📄log
✔️ 34bcd1c #1 2025-10-02 11:13:28 ~16 min linux/x86_64 📦tgz
✔️ 34bcd1c #1 2025-10-02 11:14:19 ~17 min macos/aarch64 🍎dmg
✔️ 34bcd1c #1 2025-10-02 11:15:13 ~18 min tests/ui 📄log
✔️ 34bcd1c #1 2025-10-02 11:18:00 ~21 min macos/aarch64-nwaku 🍎dmg
✔️ 34bcd1c #1 2025-10-02 11:19:23 ~22 min linux/x86_64-nwaku 📦tgz
✔️ 34bcd1c #1 2025-10-02 11:24:05 ~27 min windows/x86_64 💿exe
✖️ 34bcd1c pr18945 2025-10-02 11:28:39 ~15 min tests/e2e 📊rpt
✔️ 6033c12e #2 2025-10-03 17:29:10 ~13 min android/arm64 🤖apk 📲
✔️ 21354858 #3 2025-10-04 17:21:46 ~6 min android/arm64 🤖apk 📲
✔️ ec7ee55 #2 2025-10-06 08:57:08 ~7 min tests/nim 📄log
✔️ ec7ee55 #4 2025-10-06 08:58:24 ~8 min android/arm64 🤖apk 📲
✔️ ec7ee55 #2 2025-10-06 08:58:40 ~9 min ios/aarch64 📦pkg
✔️ ec7ee55 #2 2025-10-06 09:03:22 ~13 min tests/ui 📄log
✔️ ec7ee55 #2 2025-10-06 09:06:20 ~16 min linux/x86_64 📦tgz
✔️ ec7ee55 #2 2025-10-06 09:06:46 ~17 min macos/aarch64-nwaku 🍎dmg
✔️ ec7ee55 #2 2025-10-06 09:11:08 ~21 min linux/x86_64-nwaku 📦tgz
✔️ ec7ee55 #3 2025-10-06 09:12:47 ~13 min macos/aarch64 🍎dmg
✔️ ec7ee55 #2 2025-10-06 09:13:50 ~24 min windows/x86_64 💿exe
✖️ ec7ee55 pr18945 2025-10-06 09:22:11 ~15 min tests/e2e 📊rpt
✔️ 9dbb9cef #5 2025-10-06 09:51:33 ~6 min android/arm64 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8f2798b #3 2025-10-06 09:55:35 ~10 min ios/aarch64 📦pkg
✔️ 8f2798b #4 2025-10-06 09:55:35 ~10 min macos/aarch64 🍎dmg
✔️ 8f2798b #3 2025-10-06 09:56:11 ~11 min tests/nim 📄log
✔️ 8f2798b #3 2025-10-06 10:02:52 ~17 min macos/aarch64-nwaku 🍎dmg
✔️ 8f2798b #3 2025-10-06 10:04:49 ~20 min linux/x86_64 📦tgz
✔️ 8f2798b #3 2025-10-06 10:05:22 ~20 min tests/ui 📄log
✔️ 8f2798b #3 2025-10-06 10:06:38 ~21 min linux/x86_64-nwaku 📦tgz
✔️ 8f2798b #3 2025-10-06 10:20:39 ~35 min windows/x86_64 💿exe
✖️ 8f2798b pr18945 2025-10-06 10:22:00 ~17 min tests/e2e 📊rpt
✔️ da056c1 #5 2025-10-06 22:46:53 ~6 min tests/nim 📄log
✔️ da056c1 #8 2025-10-06 22:47:06 ~6 min android/arm64 🤖apk 📲
✔️ da056c1 #5 2025-10-06 22:47:36 ~7 min ios/aarch64 📦pkg
✔️ da056c1 #5 2025-10-06 22:54:15 ~13 min tests/ui 📄log
✔️ da056c1 #5 2025-10-06 22:56:56 ~16 min linux/x86_64 📦tgz
✔️ da056c1 #6 2025-10-06 22:57:26 ~16 min macos/aarch64 🍎dmg
✔️ da056c1 #5 2025-10-06 23:01:59 ~21 min linux/x86_64-nwaku 📦tgz
✔️ da056c1 pr18945 2025-10-06 23:11:53 ~14 min tests/e2e 📊rpt
✔️ da056c1 #5 2025-10-06 23:15:03 ~34 min windows/x86_64 💿exe

Copy link
Contributor

@noeliaSD noeliaSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added 2 minor comments.
It looks really nice in both screen sizes. I like how you used the LayoutItemProxy here! LGTM!

@micieslak micieslak force-pushed the feat/issue-18190 branch 2 times, most recently from ec7ee55 to 8f2798b Compare October 6, 2025 09:44
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work!

@micieslak micieslak merged commit 2af6a6e into master Oct 6, 2025
11 of 12 checks passed
@micieslak micieslak deleted the feat/issue-18190 branch October 6, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Mobile] Wallet's list of saved addresses is not scrollable [Mobile] Wallet account header / network combo cut off on mobile layout

4 participants