[Mobile]: ChatView: automatic open/close of members panel in swipe view mode #18917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micieslak
requested review from
alexjba,
caybro and
noeliaSD
as code owners
Jenkins BuildsClick to see older builds (37)
|
caybro
approved these changes
Sep 26, 2025
micieslak
force-pushed
the
fix/issue-18280
branch
from
a1816bc to
c6e99db
Compare
noeliaSD
reviewed
Oct 1, 2025
micieslak
force-pushed
the
fix/issue-18280
branch
from
c6e99db to
4f9eb7a
Compare
noeliaSD
reviewed
Oct 3, 2025
noeliaSD
reviewed
Oct 3, 2025
noeliaSD
approved these changes
Oct 3, 2025
micieslak
force-pushed
the
fix/issue-18280
branch
from
c8b5954 to
101abad
Compare
Manual increment/decrement were leading to setting value out of range in some cases.
It gives ability to add custom actions when the panels are swiped.
Now the usage of that ctx property is centralized in a single place in AppMain
New store added intended to encapsulate access to localAccountSensitiveSettings ctx property.
micieslak
force-pushed
the
fix/issue-18280
branch
from
101abad to
fea6074
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
It makes "members" panel working as expected on mobile.
Moreover:
goToNextPanel/goToPreviousPaneleliminating some subtle issues related to that functionalityChatHeaderContentViewswipesignal exposed fromStatusSectionLayoutlocalAccountSensitiveSettingsusages removed fromChatView/ChatHeaderContentViewCloses: #18280
Affected areas
ChatView,ChatHeaderContentView,StatusSectionLayoutArchitecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Screencast.from.25.09.2025.17.46.27.webm
Risk
Low