chore(e2e_appium): fixture for create with recovery phrase #18698
Conversation
Jenkins BuildsClick to see older builds (25)
|
| time.sleep(0.3) | ||
| if not self.is_continue_button_enabled(): | ||
| self.logger.error( | ||
| "Continue button is not enabled - seed phrase may be invalid" |
There was a problem hiding this comment.
Any way to catch error message from UI instead and log it ? Ideally we should not get invalid seed as input for autotest and its better to catch real error anyway
There was a problem hiding this comment.
I agree that it's unlikely to be invalid when using the phrase generators.
Currently it's not possible to locate the error message via XML dumps. The UI issue being captured is that the Continue button is disabled. I will remove this section though as it's mostly redundant with safe_click being used by click_continue.
| validate_each_step=True, | ||
| create_profile_method="random", | ||
| ) | ||
| def test_onboarding_create_random_lands_on_main_app(self, onboarded_app): |
There was a problem hiding this comment.
i am little bit confused it is delivered as a single test, that should be a precondition for any test to start with:
- you either create a new user with password
- or you create new profile with seed
- or you login to the app that has already a data folder (aka Returning user)
in all these cases the end result is landing to main screen
suggest to redo it the way it could be one fixture with variety of choices (new user, or returning user) and pass it to test
There was a problem hiding this comment.
The 3 tests just validate the fixture itself works with the different profile creation methods (password, seed phrase, random). As before, they may be removed or amended when it's ready for actual tests.
This PR delivers only the ability to create a new account via seed phrase or password. Extending the fixture to cover returning users is the next step for this and will be an additional config like returning_user=True or similar (task #18703).
What does the PR do
closes #18692
Updates
onboarded_appfixture in the e2e_appium test framework for multiple new user creation methods. The fixture introduces acreate_profile_methodparameter allowing tests to select:Affected areas
Impact on end user
None
Testing
python scripts/run_tests.py --category onboardingtest_onboarding_create_with_password_lands_on_main_apptest_onboarding_create_with_seed_lands_on_main_apptest_onboarding_create_random_lands_on_main_appRisk
Low risk