fix(swap): build paraswap tx error #17840
Merged
+118
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saledjenic
requested review from
alaibe,
dlipicar,
Cuteivist,
Khushboo-dev-cpp,
virginiabalducci and
a team
saledjenic
requested review from
micieslak,
caybro,
alexjba and
a team
as code owners
Jenkins BuildsClick to see older builds (21)
|
caybro
reviewed
Apr 25, 2025
| @@ -520,6 +520,7 @@ QtObject { | |||
| tokenKey, | |||
| /*amountOut = */ "0", | |||
| /*toToken =*/ "", | |||
| /*slippagePercentage*/ "", | |||
| popup.store.suggestedRoutes(d.uuid, | ||
| d.isCollectiblesTransfer ? "1" : amountToSend.amount, | ||
| /* amountOut */ "0", | ||
| /* slippagePercentage */ "", |
There was a problem hiding this comment.
Suggested change
| /* slippagePercentage */ "", | |
| /* slippagePercentage */ 0.0, |
| } | ||
|
|
||
| function suggestedRoutes(uuid, amountIn, amountOut = "0", extraParamsJson = "") { | ||
| function suggestedRoutes(uuid, amountIn, amountOut = "0", slippagePercentage = "", extraParamsJson = "") { |
There was a problem hiding this comment.
Suggested change
| function suggestedRoutes(uuid, amountIn, amountOut = "0", slippagePercentage = "", extraParamsJson = "") { | |
| function suggestedRoutes(uuid, amountIn, amountOut = "0", slippagePercentage = 0.0, extraParamsJson = "") { |
There was a problem hiding this comment.
@caybro but expected type on the Nim side is string, and then we parse it.
Check here:
status-desktop/src/app/modules/main/wallet_section/send_new/view.nim
Lines 32 to 45 in aa03be9
There was a problem hiding this comment.
I see... it's just that in swap adaptor/form, it's declared as a double
saledjenic
force-pushed
the
fix/swap-build-tx-error
branch
from
b7b3299 to
aa03be9
Compare
This was referenced Apr 25, 2025
saledjenic
force-pushed
the
fix/swap-build-tx-error
branch
2 times, most recently
from
ff5a52a to
724f934
Compare
virginiabalducci
approved these changes
May 5, 2025
2 tasks
After improvements on the fees calculation the build transaction 1001 error started to occur. It was because of missed slippage param when doing the build tx call. Fixed on the statusgo side. These changes also bring some improvements on setting custom slippage.
saledjenic
force-pushed
the
fix/swap-build-tx-error
branch
from
724f934 to
3ce9c54
Compare
alaibe
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After improvements on the fees calculation the build transaction 1001 error started to occur. It was because of missed slippage param when doing the build tx call. Fixed on the statusgo side.
These changes also bring some improvements on setting custom slippage.
Corresponding
status-gochanges: