feat(news): hook settings to the backend #17817
Open
+170
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
micieslak,
caybro,
alexjba and
a team
as code owners
Jenkins BuildsClick to see older builds (7)
|
caybro
reviewed
Apr 22, 2025
| @@ -11,9 +11,11 @@ QtObject { | |||
| readonly property string keyUid: userProfile.keyUid | |||
|
|
|||
| // The following properties wrap Privacy and Security View related properties: | |||
| property bool isStatusNewsViaRSSEnabled: true /*TODO: Connect it to the backend corresponding property*/ | |||
| property bool isStatusNewsViaRSSEnabled: appSettings.newsRSSEnabled | |||
| @@ -55,6 +55,9 @@ const PROFILE_MIGRATION_NEEDED* = "profile-migration-needed" | |||
| const KEY_URL_UNFURLING_MODE* = "url-unfurling-mode" | |||
| const KEY_AUTO_REFRESH_TOKENS* = "auto-refresh-tokens-enabled" | |||
| const KEY_LAST_TOKENS_UPDATE* = "last-tokens-update" | |||
| const KEY_NEWS_FEED_ENABLED* = "news-feed-enabled?" | |||
| const KEY_NEWS_NOTIFICATIONS_ENABLED* = "news-notifications-enabled?" | |||
| const KEY_NEWS_RSS_ENABLED* = "news-rss-enabled?" | |||
There was a problem hiding this comment.
I just wouldn't use the question marks in the settings' keys
There was a problem hiding this comment.
Yeah I get your point, but I can't do much about it, it was merged already with the question mark in status-go (not my PR)
There was a problem hiding this comment.
Wait...but these are also used as keys for our QSettings?
There was a problem hiding this comment.
I don't think so. I see that we only use them in the service and/or DTO. I renamed the Nim properties and QProperties to something nicer like newsRSSEnabled.
noeliaSD
reviewed
Apr 22, 2025
| # We convert the bools to the right setting | ||
| # Send alerts means the News Feed is enabled + notifications are enabled | ||
| # Deliver quietly means the News Feed is enabled + notifications are disabled | ||
| # Turn off means the News Feed is disabled |
There was a problem hiding this comment.
Just to clarify.. since it confused me when I was reading!
Suggested change
| # Turn off means the News Feed is disabled | |
| # Turn off means the News Feed is disabled + notifications are disabled |
| @@ -11,9 +11,11 @@ QtObject { | |||
| readonly property string keyUid: userProfile.keyUid | |||
|
|
|||
| // The following properties wrap Privacy and Security View related properties: | |||
| property bool isStatusNewsViaRSSEnabled: true /*TODO: Connect it to the backend corresponding property*/ | |||
| property bool isStatusNewsViaRSSEnabled: appSettings.newsRSSEnabled | |||
There was a problem hiding this comment.
Now it would be better:
Suggested change
| property bool isStatusNewsViaRSSEnabled: appSettings.newsRSSEnabled | |
| readonly property bool isStatusNewsViaRSSEnabled: appSettings.newsRSSEnabled |
noeliaSD
force-pushed
the
feat/issue-17795
branch
from
dc11a2b to
ffb5eca
Compare
jrainville
force-pushed
the
feat/news-hook-settings
branch
from
2b837e2 to
e4ab15d
Compare
noeliaSD
force-pushed
the
feat/issue-17795
branch
from
ffb5eca to
815e205
Compare
Fixes #17811 Hooks the NewsFeedNotification setting and the RSS setting to the backend. The Notification setting has a bit of complexity on the service side, because while the UI setting is a select of 3 options, the status-go settings are actually 2 bool settings. So the service does some logic to set the right setting from those two. The settings are used to disable the polling if one of the settings is disabled. If the setting is on DeliverQuietly, the AC notif is shown, but no notificaiton
jrainville
force-pushed
the
feat/news-hook-settings
branch
from
e4ab15d to
468275a
Compare
noeliaSD
approved these changes
Apr 24, 2025
caybro
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17811
Based on top of #17809
Status-go PR: status-im/status-go#6540
Hooks the NewsFeedNotification setting and the RSS setting to the backend.
The Notification setting has a bit of complexity on the service side, because while the UI setting is a select of 3 options, the status-go settings are actually 2 bool settings. So the service does some logic to set the right setting from those two.
The settings are used to disable the polling if one of the settings is disabled. If the setting is on DeliverQuietly, the AC notif is shown, but no OS or toast notification
What does the PR do
Hooks the UI settings to the backend settings. Makes the UX for the News Feed complete, once the feature flag on the status-go side is enabled and once we'll have a good RSS feed for Status
Affected areas
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality
settings-hooked.webm
Impact on end user
None without the feature flag on
Once it's turned on, it let's users choose the right settings for notifications or if they want to disable the feature altogether.
How to test
Risk
Nonce since the feature flag is disabled
Tick one: