Skip to content

[News Feed] Hook the News Feed and RSS UI settings to the backend #17811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
noeliaSD opened this issue Apr 17, 2025 · 0 comments · Fixed by #17817
Closed

[News Feed] Hook the News Feed and RSS UI settings to the backend #17811

noeliaSD opened this issue Apr 17, 2025 · 0 comments · Fixed by #17817
Assignees
@jrainville
Labels
core-team feature

Comments

@noeliaSD
Copy link
Contributor

noeliaSD commented Apr 17, 2025 •
edited
Loading

Description

This task involves integrating the UI settings for the News Feed and RSS features with the backend to ensure that user preferences and configurations are properly managed and stored. This will enable seamless interaction between the frontend and the backend for these functionalities.

Key points

1. Indentify UI Settings:

Depends on: #17795

  • In PrivacyStore it has been created a boolean property called isStatusNewsViaRSSEnabled that it's intended to be the setting to be hooked to the backend property to set up the Status News via RSS.

  • NotificationsView refers to a property called notifSettingStatusNewsthat it's intended to be the setting to be hooked to the backend property to set up the status of the news feed notifications with the following possible values:

    • Constants.settingsSection.notifications.sendAlertsValue
    • Constants.settingsSection.notifications.deliverQuietlyValue
    • Constants.settingsSection.notifications.turnOffValue

    This new property is expected to be under appSettings called from NotificationsStore.

2. Define Data Flow:

  • Establish how data flows from the frontend to the backend and vice versa. This includes ensuring that settings changed by the user in the UI are saved to the backend and that saved configurations are fetched and displayed correctly in the UI.

3. Backend Integration:

  • If the backend already has APIs for these settings:
    • Integrate the frontend with these APIs.
    • Ensure proper request and response handling.
  • If the APIs do not exist:
    • Define the necessary endpoints and data management.

Acceptance Criteria

  • Fully functional integration of News Feed and RSS UI settings with the backend.
  • Ensure that user preferences are persistently stored in the database and are not lost between sessions.
@jrainville jrainville moved this from Next to In Progress in Status Desktop/Mobile Board Apr 17, 2025
jrainville added a commit to status-im/status-go that referenced this issue Apr 17, 2025
@jrainville
feat(news)_: hook News settings to the newsFeedManager and its polling
93eb3d0 
Needed for status-im/status-desktop#17811

Adds the NewsRSSEnabled setting that is going to be used in the Privacy settings of the clients.

Adds API methods to toggle the NewsFeedEnabled  and NewsRSSEnabled settings.
By doing so, it will trigger the NewsFeedManager polling if both settings are set to true.
Conversely, if one of them is disabled, it stops the polling.
jrainville added a commit to status-im/status-go that referenced this issue Apr 17, 2025
@jrainville
feat(news)_: hook News settings to the newsFeedManager and its polling
6f064e5 
Needed for status-im/status-desktop#17811

Adds the NewsRSSEnabled setting that is going to be used in the Privacy settings of the clients.

Adds API methods to toggle the NewsFeedEnabled  and NewsRSSEnabled settings.
By doing so, it will trigger the NewsFeedManager polling if both settings are set to true.
Conversely, if one of them is disabled, it stops the polling.
jrainville added a commit to status-im/status-go that referenced this issue Apr 18, 2025
@jrainville
feat(news)_: hook News settings to the newsFeedManager and its polling
e62ea86 
Needed for status-im/status-desktop#17811

Adds the NewsRSSEnabled setting that is going to be used in the Privacy settings of the clients.

Adds API methods to toggle the NewsFeedEnabled  and NewsRSSEnabled settings.
By doing so, it will trigger the NewsFeedManager polling if both settings are set to true.
Conversely, if one of them is disabled, it stops the polling.
jrainville added a commit that referenced this issue Apr 18, 2025
@jrainville
feat(news): hook settings to the backend
a1de2ae 
Fixes #17811

Hooks the NewsFeedNotification setting and the RSS setting to the backend.
The Notification setting has a bit of complexity on the service side, because while the UI setting is a select of 3 options, the status-go settings are actually 2 bool settings. So the service does some logic to set the right setting from those two.
The settings are used to disable the polling if one of the settings is disabled. If the setting is on DeliverQuietly, the AC notif is shown, but no notificaiton
@jrainville jrainville mentioned this issue Apr 18, 2025
Merged
jrainville added a commit that referenced this issue Apr 18, 2025
@jrainville
feat(news): hook settings to the backend
2b837e2 
Fixes #17811

Hooks the NewsFeedNotification setting and the RSS setting to the backend.
The Notification setting has a bit of complexity on the service side, because while the UI setting is a select of 3 options, the status-go settings are actually 2 bool settings. So the service does some logic to set the right setting from those two.
The settings are used to disable the polling if one of the settings is disabled. If the setting is on DeliverQuietly, the AC notif is shown, but no notificaiton
@jrainville jrainville mentioned this issue Apr 18, 2025
Merged
3 tasks
@jrainville jrainville moved this from In Progress to Code Review in Status Desktop/Mobile Board Apr 18, 2025
jrainville added a commit that referenced this issue Apr 22, 2025
@jrainville
feat(news): hook settings to the backend
e4ab15d 
Fixes #17811

Hooks the NewsFeedNotification setting and the RSS setting to the backend.
The Notification setting has a bit of complexity on the service side, because while the UI setting is a select of 3 options, the status-go settings are actually 2 bool settings. So the service does some logic to set the right setting from those two.
The settings are used to disable the polling if one of the settings is disabled. If the setting is on DeliverQuietly, the AC notif is shown, but no notificaiton
jrainville added a commit to status-im/status-go that referenced this issue Apr 22, 2025
@jrainville
feat(news)_: hook News settings to the newsFeedManager and its polling
d913c62 
Needed for status-im/status-desktop#17811

Adds the NewsRSSEnabled setting that is going to be used in the Privacy settings of the clients.

Adds API methods to toggle the NewsFeedEnabled  and NewsRSSEnabled settings.
By doing so, it will trigger the NewsFeedManager polling if both settings are set to true.
Conversely, if one of them is disabled, it stops the polling.
jrainville added a commit that referenced this issue Apr 23, 2025
@jrainville
feat(news): hook settings to the backend
468275a 
Fixes #17811

Hooks the NewsFeedNotification setting and the RSS setting to the backend.
The Notification setting has a bit of complexity on the service side, because while the UI setting is a select of 3 options, the status-go settings are actually 2 bool settings. So the service does some logic to set the right setting from those two.
The settings are used to disable the polling if one of the settings is disabled. If the setting is on DeliverQuietly, the AC notif is shown, but no notificaiton
jrainville added a commit to status-im/status-go that referenced this issue Apr 23, 2025
@jrainville
feat(news)_: hook News settings to the newsFeedManager and its polling
f96b3da 
Needed for status-im/status-desktop#17811

Adds the NewsRSSEnabled setting that is going to be used in the Privacy settings of the clients.

Adds API methods to toggle the NewsFeedEnabled  and NewsRSSEnabled settings.
By doing so, it will trigger the NewsFeedManager polling if both settings are set to true.
Conversely, if one of them is disabled, it stops the polling.
jrainville added a commit to status-im/status-go that referenced this issue May 5, 2025
@jrainville
feat(news)_: hook News settings to the newsFeedManager and its polling
1902207 
Needed for status-im/status-desktop#17811

Adds the NewsRSSEnabled setting that is going to be used in the Privacy settings of the clients.

Adds API methods to toggle the NewsFeedEnabled  and NewsRSSEnabled settings.
By doing so, it will trigger the NewsFeedManager polling if both settings are set to true.
Conversely, if one of them is disabled, it stops the polling.
jrainville added a commit to status-im/status-go that referenced this issue May 7, 2025
@jrainville
feat(news)_: hook News settings to the newsFeedManager and its polling
a89604d 
Needed for status-im/status-desktop#17811

Adds the NewsRSSEnabled setting that is going to be used in the Privacy settings of the clients.

Adds API methods to toggle the NewsFeedEnabled  and NewsRSSEnabled settings.
By doing so, it will trigger the NewsFeedManager polling if both settings are set to true.
Conversely, if one of them is disabled, it stops the polling.
jrainville added a commit that referenced this issue May 7, 2025
@jrainville
feat(news): hook settings to the backend
9efe2ee 
Fixes #17811

Hooks the NewsFeedNotification setting and the RSS setting to the backend.
The Notification setting has a bit of complexity on the service side, because while the UI setting is a select of 3 options, the status-go settings are actually 2 bool settings. So the service does some logic to set the right setting from those two.
The settings are used to disable the polling if one of the settings is disabled. If the setting is on DeliverQuietly, the AC notif is shown, but no notificaiton
jrainville added a commit that referenced this issue May 7, 2025
@jrainville
feat(news): hook settings to the backend
aa0db7b 
Fixes #17811

Hooks the NewsFeedNotification setting and the RSS setting to the backend.
The Notification setting has a bit of complexity on the service side, because while the UI setting is a select of 3 options, the status-go settings are actually 2 bool settings. So the service does some logic to set the right setting from those two.
The settings are used to disable the polling if one of the settings is disabled. If the setting is on DeliverQuietly, the AC notif is shown, but no notificaiton
jrainville added a commit to status-im/status-go that referenced this issue May 8, 2025
@jrainville
feat(news)_: hook News settings to the newsFeedManager and its polling
055d25c 
Needed for status-im/status-desktop#17811

Adds the NewsRSSEnabled setting that is going to be used in the Privacy settings of the clients.

Adds API methods to toggle the NewsFeedEnabled  and NewsRSSEnabled settings.
By doing so, it will trigger the NewsFeedManager polling if both settings are set to true.
Conversely, if one of them is disabled, it stops the polling.
jrainville added a commit that referenced this issue May 8, 2025
@jrainville
feat(news): hook settings to the backend
b10d311 
Fixes #17811

Hooks the NewsFeedNotification setting and the RSS setting to the backend.
The Notification setting has a bit of complexity on the service side, because while the UI setting is a select of 3 options, the status-go settings are actually 2 bool settings. So the service does some logic to set the right setting from those two.
The settings are used to disable the polling if one of the settings is disabled. If the setting is on DeliverQuietly, the AC notif is shown, but no notificaiton
jrainville added a commit to status-im/status-go that referenced this issue May 8, 2025
@jrainville
feat(news)_: hook News settings to the newsFeedManager and its polling
8e95282 
Needed for status-im/status-desktop#17811

Adds the NewsRSSEnabled setting that is going to be used in the Privacy settings of the clients.

Adds API methods to toggle the NewsFeedEnabled  and NewsRSSEnabled settings.
By doing so, it will trigger the NewsFeedManager polling if both settings are set to true.
Conversely, if one of them is disabled, it stops the polling.
jrainville added a commit to status-im/status-go that referenced this issue May 8, 2025
@jrainville
feat(news)_: hook News settings to the newsFeedManager and its polling (
e1096ea 
#6540)

Needed for status-im/status-desktop#17811

Adds the NewsRSSEnabled setting that is going to be used in the Privacy settings of the clients.

Adds API methods to toggle the NewsFeedEnabled  and NewsRSSEnabled settings.
By doing so, it will trigger the NewsFeedManager polling if both settings are set to true.
Conversely, if one of them is disabled, it stops the polling.
jrainville added a commit that referenced this issue May 8, 2025
@jrainville
feat(news): hook settings to the backend
aef3d0f 
Fixes #17811

Hooks the NewsFeedNotification setting and the RSS setting to the backend.
The Notification setting has a bit of complexity on the service side, because while the UI setting is a select of 3 options, the status-go settings are actually 2 bool settings. So the service does some logic to set the right setting from those two.
The settings are used to disable the polling if one of the settings is disabled. If the setting is on DeliverQuietly, the AC notif is shown, but no notificaiton
@github-project-automation github-project-automation bot moved this from Code Review to Done in Status Desktop/Mobile Board May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrainville jrainville

Labels
core-team feature
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(news): hook settings to the backend status-im/status-desktop
2 participants
@jrainville @noeliaSD