add: columns to Eth2Processor and BlockProcessor
#6862
Draft
+475
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersec
reviewed
Jan 20, 2025
| @@ -199,9 +245,62 @@ proc get_data_column_sidecars*(signed_beacon_block: electra.TrustedSignedBeaconB | |||
|
|
|||
| sidecars | |||
|
|
|||
| # Additional overload to perform reconstruction at the time of gossip | |||
There was a problem hiding this comment.
tersec
reviewed
Jan 20, 2025
| return err("DataColumnSidecar: Length should not be 0") | ||
|
|
||
| var | ||
| columnCount = data_columns.len |
tersec
reviewed
Jan 20, 2025
|
|
||
| var | ||
| columnCount = data_columns.len | ||
| blobCount = data_columns[0].column.len |
tersec
reviewed
Jan 20, 2025
| for column_index in 0..<NUMBER_OF_COLUMNS: | ||
| var | ||
| column_cells: seq[KzgCell] | ||
| column_proofs: seq[KzgProof] |
There was a problem hiding this comment.
Both of these could use newSeqOfCap with cellsAndProofs.len
tersec
reviewed
Jan 20, 2025
| @@ -130,6 +143,28 @@ proc routeSignedBeaconBlock*( | |||
| msg = res.error() | |||
| return err(res.error()) | |||
|
|
|||
| # May not be required as we are already | |||
| # kzg verifying the blobs once | |||
There was a problem hiding this comment.
KZG is an acronym, or at least capitalized like one
tersec
reviewed
Jan 20, 2025
|
|
||
| let kzgCommits = | ||
| signedBlock.message.body.blob_kzg_commitments.asSeq | ||
| if dataColumns.len > 0 and kzgCommits.len > 0: |
There was a problem hiding this comment.
This doesn't seem to actually use kzgCommits though, aside from this check?
(Also, if it's just checking len, it shouldn't need asSeq)
tersec
reviewed
Jan 20, 2025
| for dc in data_columns: | ||
| if dc.index in custody_columns: | ||
| final_columns.add dc | ||
| dataColumnRefs = Opt.some(final_columns.mapIt(newClone(it))) |
There was a problem hiding this comment.
Why even create the non-ref final_columns to begin with, only to mapIt immediately?
Once you know you're going to set dataColumnRefs = Opt.some ..., can build it up in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.