Initial commit for eip-7732 on fulu #6768
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tomi-3-0
commented
Dec 18, 2024
Tomi-3-0
commented
- Execution payloads are removed from the beacon block structure.
- Slot intervals are increased to 4 to align with EIP-7732 timing changes.
- Refactored validators and consensus object pools for compatibility.
This commit introduces changes to support EIP-7732 in the Fulu fork: - Execution payloads are removed from the beacon block structure. - Slot intervals are increased to 4 to align with EIP-7732 timing changes. - Refactored validators and consensus object pools for compatibility.
operations across blob quarantine, gossip validation, sync, and validator flows
Tomi-3-0
force-pushed
the
feat/eip-7732
branch
from
b97a1d5 to
7b144dc
Compare
|
|
Initially omitted adding Thanks. |
Tomi-3-0
force-pushed
the
feat/eip-7732
branch
from
7b144dc to
3e016d2
Compare
|
tersec
reviewed
Jan 5, 2025
|
Why does |
That To run all the tests, |
Tomi-3-0
force-pushed
the
feat/eip-7732
branch
2 times, most recently
from
e47ceb1 to
0e9e2c8
Compare
|
Causing Electra fork test failures on macos and Windows: |
|
Thanks What's the best way to reproduce this error locally? |
I was able to do so by cloning your repro/branch ( The most targeted way to reproduce this locally is either for the mainnet version or for the minimal version. |
|
Thanks I had to download the test vectors manually using the provided script: cd vendor/nim-eth2-scenarios && ./download_test_vectors.sh
Thanks I had to download the test vectors manually: cd vendor/nim-eth2-scenarios && ./download_test_vectors.sh |
|
Ok, that works, but |
|
Hey @Tomi-3-0, can you send me an invite to your repo? |
Tomi-3-0
force-pushed
the
feat/eip-7732
branch
2 times, most recently
from
91c62a3 to
ac49cfe
Compare
Hi @shyam-patel-kira , sent an invite |
to reproduce, should suffice. |
Since |
Well, for me, they do pick up the issue. I did:
Both |
Thank you. I will go through this again |
payload signature tests, update toSignedBlindedBeaconBlock
Tomi-3-0
force-pushed
the
feat/eip-7732
branch
from
ac49cfe to
960c790
Compare
|
| quarantine[].addUnviable(signed_beacon_block.root) | ||
| return dag.checkedReject( | ||
| "BeaconBlock: mismatched execution payload timestamp") | ||
| when signed_beacon_block is fulu.SignedBeaconBlock: |
There was a problem hiding this comment.
Why are we discarding a signed_beacon_block from fulu here? If a block belongs to fulu it shouldn't enter validateBeaconBlockBellatrix, right? Or am I missing something?
There was a problem hiding this comment.
The validateBeaconBlockBellatrix is a generic template to allow code reuse while maintaining type safety, accepting multiple SignedBeaconBlock types from Bellatrix upwards.
Since fulu blocks have had the execution_payload removed from their beaconblocks, we need to handle them explicitly with when signed_beacon_block is fulu.SignedBeaconBlock: discard to skip the timestamp validation that depends on the execution payload
|
Hey @Tomi-3-0, can we avoid force pushing commit, now even a 1-commit change PR shows a lot of commits on my end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.