Add option to produce only singlets probabilities (fix #52) #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think Fix #59 would fix the OOM issue |
Author
|
@VincentGardeux thanks for the info, but I already wrote my own demultiplexer for rnaseq, I can close this PR if you're confident that problem with too many genotypes was addressed in your patch. |
|
@arogozhnikov yes the patch corrects the issue. I did not change much the code, so I don't see any potential conflicts/bugs, but would be cool if would be tested on a test dataset at least by another user before merging (we tested it on several datasets and did not see any difference of output (to the byte). Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing PR because running demuxlet against large number of genotypes drives to OOM