-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster null fit #102
Draft
ailurophilia
wants to merge
169
commits into
statdivlab:ailurophilia-main
Choose a base branch
from
ailurophilia:faster_null_fit
base: ailurophilia-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Faster null fit #102
ailurophilia
wants to merge
169
commits into
statdivlab:ailurophilia-main
from
ailurophilia:faster_null_fit
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugh pkgdown.yaml workflow.
… so that the pkgdown.yaml workflow actually uses the logo for the github.io page.
Create github.io webpage using pkgdown
…tor vector or the name of a variable in `data`, adding tests to make sure the argument works for all of these cases
…ata` (this code was confusing and not working in tests called by github actions, I think a better way to implement this if desired would be through the formula object)
remove old code defining unused variable `cluster_name`
update `emuFit()` so that it won't run into error with `penalize = FA…
…nder null hypotheses (if score tests are fit) - used for debugging
…d vignette are built. (update this again once PRs with additional vignettes are merged)
Parallel vignette
…formula and data arguments)
…cal flag match_row_names to the parameters. Started test-that file for this row name matching in the data frame.
…sts worked with the added message that warns when rownames are missing.
This addresses feature request/issue statdivlab#88
…g process, but we may remove p-value check soon.
add option to return score test components
Matching row names
Updating local files with upstream files.
add plotting demo to radEmu vignettes
Make simulate_data() for internal use and apply in the testthat files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
fit_null_repar
, a couple helper functions, and a test to confirm this finds the same null fit as the augmented lagrangian approach.Instead of using a constrained optimization method,
fit_null_repar
treats B_k_constr_j_constr as a function of the remaining elements of B_k_constr and solves the resulting (likelihood) optimization problem by coordinate descent. This is similar to but not the same as the coordinate descent algorithm used in full model fitting. The main differences are the followingIn my experience so far, this outperforms the augmented lagrangian approach both in stability (I have yet to see it fail) and in scalability (I'm able to fit nulls in J = 1000 categories in a matter of 10 or 20 minutes even when B[k_constr,j_constr] has a large value under the full model fit.
However,
fit_null_repar
as a replacement for / alternative tofit_null
, and I have added a test comparing these two algorithms on a toy problem, but I have not integratedfit_null_repar
intoscore_test
, which will be the next step needed to incorporate this algorithm intoradEmu
.