Skip to content

fix(ui): TE-2649 show recommnded datasource in create datasource json editor #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nalin-patidar wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(ui): TE-2649 show recommnded datasource in create datasource json editor #1793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions thirdeye-ui/src/app/pages/datasources-create-page/datasources-create-page.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* the License.
*/
import { AxiosError } from "axios";
import React, { FunctionComponent } from "react";
import React, { FunctionComponent, useEffect, useState } from "react";
import { useTranslation } from "react-i18next";
import { useNavigate } from "react-router-dom";
import { DatasourceWizard } from "../../components/datasource-wizard/datasource-wizard.component";
Expand All @@ -36,11 +36,39 @@ import {
getDatasourcesAllPath,
getDatasourcesViewPath,
} from "../../utils/routes/routes.util";
import { useGetRecommendedDatasources } from "../../rest/datasources/datasources.actions";

export const DatasourcesCreatePage: FunctionComponent = () => {
const navigate = useNavigate();
const { t } = useTranslation();
const { notify } = useNotificationProviderV1();
const [defaultDatasource, setDefaultDatasource] = useState<Datasource>(
createDefaultDatasource()
);

const {
recommendedDatasource,
getRecommendedDatasource,
status: recommendedDatasourcesStatus,
errorMessages: recommendedDatasourcesErrormessage,
} = useGetRecommendedDatasources();

useEffect(() => {
getRecommendedDatasource();
}, []);

useEffect(() => {
recommendedDatasource && setDefaultDatasource(recommendedDatasource);
}, [recommendedDatasource]);

useEffect(() => {
notifyIfErrors(
recommendedDatasourcesStatus,
recommendedDatasourcesErrormessage,
notify,
t("errors.pinot-instance-not-created")
);
}, [recommendedDatasourcesStatus]);

const onDatasourceWizardFinish = (
datasource: Datasource,
Expand Down Expand Up @@ -107,7 +135,7 @@ export const DatasourcesCreatePage: FunctionComponent = () => {

<DatasourceWizard
isCreate
datasource={createDefaultDatasource()}
datasource={defaultDatasource}
submitBtnLabel={t("label.create-entity", {
entity: t("label.datasource"),
})}
Expand Down
3 changes: 2 additions & 1 deletion ...s/welcome-page/create-datasource/onboard-datasource/onboard-datasource-page.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export const WelcomeSelectDatasource: FunctionComponent = () => {
}, []);

useEffect(() => {
if (datasourcesStatus === ActionStatus.Done && isEmpty(datasources)) {
if (datasourcesStatus === ActionStatus.Done) {
getRecommendedDatasource();
}
}, [datasourcesStatus, datasources]);
Expand All @@ -132,6 +132,7 @@ export const WelcomeSelectDatasource: FunctionComponent = () => {
);
});
}
recommendedDatasource && setEditedDatasource(recommendedDatasource);
}, [recommendedDatasource, datasources]);

useEffect(() => {
Expand Down