Skip to content

Conversation

@giladchase
Copy link
Contributor

No description provided.

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@giladchase giladchase marked this pull request as ready for review December 14, 2025 09:55
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi reviewed 22 of 22 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eytan-starkware and @giladchase)


a discussion (no related file):
remove "unbox" from the set of movable functions - as no longer required listing.

@giladchase giladchase force-pushed the gilad/12-14-feat_add_unbox_for_symmetry_with_intobox_ branch from 9b151ef to 0316145 Compare December 14, 2025 11:09
@giladchase giladchase force-pushed the gilad/12-08-add_intobox_instead_of_into_box_in_lowering branch from 6f5a62c to 2ace016 Compare December 14, 2025 11:11
@giladchase giladchase force-pushed the gilad/12-14-feat_add_unbox_for_symmetry_with_intobox_ branch from 0316145 to eca350a Compare December 14, 2025 11:11
@giladchase giladchase force-pushed the gilad/12-08-add_intobox_instead_of_into_box_in_lowering branch from 2ace016 to 0161d5c Compare December 14, 2025 11:12
@giladchase giladchase force-pushed the gilad/12-14-feat_add_unbox_for_symmetry_with_intobox_ branch from eca350a to 5678893 Compare December 14, 2025 11:12
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@orizi reviewed 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eytan-starkware and @giladchase)

@giladchase giladchase force-pushed the gilad/12-14-feat_add_unbox_for_symmetry_with_intobox_ branch from 5678893 to 99620ed Compare December 14, 2025 11:33
@giladchase giladchase force-pushed the gilad/12-08-add_intobox_instead_of_into_box_in_lowering branch from 0161d5c to 3ab237f Compare December 14, 2025 11:33
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eytan-starkware and @giladchase)

@giladchase giladchase force-pushed the gilad/12-08-add_intobox_instead_of_into_box_in_lowering branch from 3ab237f to 868d2a7 Compare December 14, 2025 13:01
@giladchase giladchase force-pushed the gilad/12-14-feat_add_unbox_for_symmetry_with_intobox_ branch from 99620ed to faf1f35 Compare December 14, 2025 13:01
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi reviewed 4 of 4 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eytan-starkware)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants