Skip to content

chore: remove unused _name param from create_impl_generics #9004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Galoretka wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

chore: remove unused _name param from create_impl_generics #9004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/cairo-lang-proc-macros/src/debug.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ fn emit_struct_debug(
let (pat, prints) = emit_fields_debug(db, name.to_string(), &structure.fields);

// a) impl-side generics = original + 'a + T
let impl_generics = create_impl_generics(name, generics);
let impl_generics = create_impl_generics(generics);
let (impl_g, _, where_g) = impl_generics.split_for_impl();

// b) type-side generics = *original only*
Expand Down Expand Up @@ -84,7 +84,7 @@ fn emit_enum_debug(
};
}

let impl_generics = create_impl_generics(name, generics);
let impl_generics = create_impl_generics(generics);
let (impl_g, _, where_g) = impl_generics.split_for_impl();

let (_, ty_g, _) = generics.split_for_impl();
Expand Down Expand Up @@ -186,7 +186,7 @@ fn debug_crate() -> syn::Ident {
///
/// The impl generics are the original generics plus a lifetime 'db.
/// The lifetime 'db is added to the impl generics if it is not already present.
fn create_impl_generics(_name: &syn::Ident, generics: &Generics) -> Generics {
fn create_impl_generics(generics: &Generics) -> Generics {
let mut impl_generics = generics.clone();

let has_db_lifetime = impl_generics.params.iter().any(|p| {
Expand Down