Fix QM31 to not use raw internal value #163
Merged
+36
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianGCalderon
requested review from
pefontana,
dan-starkware and
gabrielbosio
as code owners
tdelabro
reviewed
Sep 25, 2025
tdelabro
approved these changes
Sep 25, 2025
gabrielbosio
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
to_rawto obtain the QM31 coefficients, instead ofrepresentative. Internally, there are two valid representation for the zero value:0andPRIME. When packing a QM31 into a felt, however, we need to use the representative value (0).Pull Request type
What is the current behavior?
We are serializing a
PRIMEcoefficient with the raw value (PRIME), instead of the representative value (0).What is the new behavior?
Serialize a
PRIMEcoefficient with the representative value (0).Does this introduce a breaking change?
No