This repository was archived by the owner on May 17, 2020. It is now read-only.
oEmbed https issues#87
Open
nicolaasmatthijs wants to merge 1 commit intostarfishmod:masterfrom
Open
Conversation
|
Interesting, I was looking into writing a proxy service to solve this issue, but I think I'll give your solution a try first. |
Author
|
@starfishmod : Is there any chance that this can be merged? Cross-protocol embedding is becoming an increasingly big problem in the latest browser versions. |
|
The NFL would like to continue support for this plugin. Please re-submit your pull request with https://github.com/nfl/jquery-oembed-all. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using oEmbed on an https page, security conscious browsers such as Chrome won't load some of the http jsonp and swf content.
In this PR, I've made the following providers protocol agnostic and tested this on both http and https:
The same approach would probably work for the other providers as well, but I haven't fixes and/or tested any of those yet.