Skip to content

fix: pystapi-validator #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

fix: pystapi-validator #66

wants to merge 15 commits into from

Conversation

j-tr
Copy link
Contributor

@j-tr j-tr commented Apr 3, 2025

What I'm changing

  • Updating Schemathesis version
  • Fixed usage
    • call_and_validate actually runs all tests internally
    • validate raises on error instead of returning a result
  • Warn but do not fail on deprecation warnings from inside Schemathesis

Currently the validator is detecting two errors

  1. Undocumented Content-Type for orders
    Received: application/geo+json
    Documented: application/json

  2. Response violates schema
    'orders' is a required property (see Rename orders field of OrderCollection to features stapi-spec#265)

Checklist

  • Tests pass: uv run pytest
  • Checks pass: uv run pre-commit --all-files
  • CHANGELOG is updated (if necessary)

@j-tr j-tr requested a review from gadomski as a code owner April 3, 2025 08:55
@j-tr j-tr removed the request for review from gadomski April 3, 2025 08:56
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way we can make CI go red to show that this is broken? E.g. add a test against a dev stapi-fastapi server? I'd like a smoke test for the validator repo if we can.

@gadomski gadomski changed the title Update & fix validator fix: pystapi-validator Apr 3, 2025
@gadomski
Copy link
Member

gadomski commented Apr 3, 2025

Marking as draft until we update the OpenAPI schema. ✨ love the update and uploading the validation report.

@gadomski gadomski marked this pull request as draft April 3, 2025 09:41
@j-tr
Copy link
Contributor Author

j-tr commented Apr 3, 2025

making the validation continue on error for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants