Add Device.WiFi.DataElements.Network.SSID subtree #3
Conversation
| return 1; | ||
| #else | ||
| return 0; | ||
| return 1; // should be 0 |
| #else | ||
| #define MLD_UNIT_COUNT 1 | ||
| #endif /* CONFIG_NO_MLD_ONLY_PRIVATE */ | ||
| //#endif /* CONFIG_NO_MLD_ONLY_PRIVATE */ |
There was a problem hiding this comment.
Do not forget to revert this change.
| wifi_vap_info_t *vapInfo = NULL; | ||
|
|
||
| wifi_util_dbg_print(WIFI_DMCLI,"%s:%d: get_total_num_vap_dml():%d nIndex:%d\n",__func__, __LINE__, get_total_num_vap_dml(), nIndex); | ||
| if (nIndex >= 0 && nIndex <= (UINT)get_total_num_vap_dml()) |
There was a problem hiding this comment.
DataElements_SSID_GetEntryCount uses and returns get_num_fronthaul_vaps(), but DataElements_SSID_GetEntry checks nIndex against get_total_num_vap_dml(). Those are different functions — inconsistent population logic.
There was a problem hiding this comment.
One more:
Using <= allows nIndex == get_total_num_vap_dml(), which is out of range if valid indices are 0..N-1.
| <parameters> | ||
| <parameter> | ||
| <name>SSID</name> | ||
| <type>string(32)</type> |
| </parameter> | ||
| <parameter> | ||
| <name>Band</name> | ||
| <type>string(32)</type> |
There was a problem hiding this comment.
Why 32?
Comma-separated list of strings. The band(s) (GHz) for which this SSID applies. Each list item is an enumeration of:
All (Applies to all bands)
2.4 (2.4 GHz band)
5 (The entire 5 GHz band)
6 (The entire 6 GHz band)
5_UNII_1 (5 GHz UNII-1 band, 5.15 to 5.25 GHz)
5_UNII_2 (5 GHz UNII-2 band, 5.25 to 5.725 GHz)
5_UNII_3 (5 GHz UNII-3 band, 5.725 to 5.85 GHz)
5_UNII_4 (5 GHz UNII-4 band, 5.85 to 5.925 GHz)
6_UNII_5 (6 GHz UNII-5 band, 5.925 to 6.425 GHz)
6_UNII_6 (6 GHz UNII-6 band, 6.425 to 6.525 GHz)
6_UNII_7 (6 GHz UNII-7 band, 6.525 to 6.875 GHz)
6_UNII_8 (6 GHz UNII-8 band, 6.875 to 7.125 GHz)
Sub_1GHz (Sub 1 GHz band, 800 MHz to 928 MHz, added in 2.19)
2 participants
No description provided.