Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexing in-memory documents #196

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

fschlatt
Copy link

I wanted to index a collection from in-memory documents. The collection loader already supports passing in-memory documents, the only issue was that the config would store and save the entire collection as well. To prevent this, I added a flag to the index function which allows specifying a collection name. The collection name is then saved instead of the in-memory collection. To make searching work, it was now also necessary to remove loading the collection before searching (since the collection config option now isn't a path but the collection name). As far as I can tell, loading the entire collection before searching is completely unecessary anyway and searching works perfectly fine without loading the collection beforehand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant