Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor run_on_pod actors and cancellation logic #874

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

cathyzbn
Copy link

@cathyzbn cathyzbn commented Feb 1, 2025

Manual Worker Termination on central 2: http://localhost:8265/#/jobs/98010000

Copy link
Member

@dlwh dlwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this is basically the right direction. a few thoughts

src/levanter/infra/ray_tpu.py Outdated Show resolved Hide resolved
src/levanter/infra/ray_tpu.py Outdated Show resolved Hide resolved
src/levanter/infra/ray_tpu.py Outdated Show resolved Hide resolved
src/levanter/infra/ray_tpu.py Outdated Show resolved Hide resolved
src/levanter/infra/ray_tpu.py Outdated Show resolved Hide resolved
src/levanter/infra/ray_tpu.py Outdated Show resolved Hide resolved
@cathyzbn cathyzbn changed the title wip: Refactor `run_on actors and cancellation logic wip: Refactor run_on_pod actors and cancellation logic Feb 10, 2025
@cathyzbn cathyzbn changed the title wip: Refactor run_on_pod actors and cancellation logic Refactor run_on_pod actors and cancellation logic Feb 12, 2025
@cathyzbn cathyzbn requested a review from dlwh February 12, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants