Skip to content

Disable netflix crashreporting to ensure stripped binary #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sverkoye wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disable netflix crashreporting to ensure stripped binary #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions recipes-example/netflix/files/0005-fix-signalhandler-disabled-crashreporting.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
From: Stefan Verkoyen <sverkoyen.contractor@libertyglobal.com>
Subject: Remove crash reporting to ensure stripped netflix

Disabling crash reporting (NRDP_HAS_CRASH_REPORTING=0) caused
build errors.

Index: netflix/src/platform/gibbon/SignalHandler.cpp
===================================================================
--- netflix.orig/src/platform/gibbon/SignalHandler.cpp
+++ netflix/src/platform/gibbon/SignalHandler.cpp
@@ -1305,7 +1305,9 @@ void SignalHandler::handleSignal(int /*s
stackTrace = CrashInfo::getBacktrace();
} else {
inStackUnwind = 1;
+#if defined(NRDP_HAS_CRASH_REPORTING)
stackTrace.set_callback(&unwind_callback, reinterpret_cast<void*>(sCrashFD));
+#endif
stackTrace.set_context(_ctx, siaddr);

sigHandlerBackup.error_addr = error_addr;
@@ -1331,6 +1333,7 @@ afterUnwind:
inStackUnwind = 0;

// TODO: Move to use YAML only and not set a variant for JSON.
+#if defined(NRDP_HAS_CRASH_REPORTING)
#define ___YAML_ARRAY_START "- "
#define ___YAML_ARRAY_INDENT " "
#define __YAML_ARRAY_START_PREFIX(key) ___YAML_ARRAY_START key
@@ -1628,6 +1631,8 @@ afterUnwind:
nflx1::writeString(sCrashFD, "...", 3);
nflx1::writeNewLine(sCrashFD);

+#endif // NRDP_HAS_CRASH_REPORTING
+
#if defined(NRDP_HAS_CRASH_REPORT)
if(Configuration::backtraceThreads()) { // try to write from threads
const std::vector<ThreadConfig*> configs = ThreadConfig::allConfigs();
6 changes: 6 additions & 0 deletions recipes-example/netflix/netflix_5.3.bbappend
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ SRC_URI += "file://0015-netflix-ui-in-1080p.patch;patchdir=${WORKDIR}/git"
EXTRA_OECMAKE_remove = "-DGIBBON_PLATFORM=${S}/../../git/partner/platform/thunder-manager"
###

### Disable crashreporting to ensure stripping of binary
SRC_URI += "file://0005-fix-signalhandler-disabled-crashreporting.patch"
EXTRA_OECMAKE_remove = "-DNRDP_HAS_CRASH_REPORTING=1"
EXTRA_OECMAKE += "-DNRDP_HAS_CRASH_REPORTING=0"
###

APPBOOTKEY = ""
DEVICEMODEL = "reference-image"
MINAUDIOPTSGAP = "0"
Expand Down