Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DEFAULT_TOLERANCE to 0.01 #119

Closed
wants to merge 4 commits into from

Conversation

gadomski
Copy link
Contributor

The current value was too high, which was allowing through huge geometries that didn't need all those points.

@gadomski gadomski requested a review from matthewhanson August 22, 2023 19:25
@gadomski gadomski self-assigned this Aug 22, 2023
@gadomski gadomski linked an issue Aug 22, 2023 that may be closed by this pull request
Copy link
Collaborator

@philvarner philvarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

The current value was too high, which was allowing through huge geometries that didn't need all those points.
@gadomski gadomski force-pushed the issues/113-change-default-tolerance branch from d96604a to b531538 Compare August 23, 2023 21:13
@matthewhanson
Copy link
Member

Added this change to #129 since the test outputs had to be recreated anyway.

@matthewhanson matthewhanson deleted the issues/113-change-default-tolerance branch November 10, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prune very large polygons
3 participants