Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build UIKitBackend in CI #119

Merged
merged 5 commits into from
Mar 27, 2025
Merged

Build UIKitBackend in CI #119

merged 5 commits into from
Mar 27, 2025

Conversation

bbrk24
Copy link
Contributor

@bbrk24 bbrk24 commented Mar 25, 2025

Only includes the build step and not the test step because xcodebuild -scheme swift-cross-ui-Package test errors out looking for GTK headers.

@bbrk24
Copy link
Contributor Author

bbrk24 commented Mar 25, 2025

Maybe I should've done a matrix rather than a bash for loop 😅

@bbrk24
Copy link
Contributor Author

bbrk24 commented Mar 25, 2025

After piping the logs through xcpretty:

❌  /Users/runner/work/swift-cross-ui/swift-cross-ui/Sources/UIKitBackend/KeyboardToolbar.swift:197:30: 'UIToolbar' is unavailable in tvOS

final class KeyboardToolbar: UIToolbar {
                             ^~~~~~~~~

It seems to have found a legitimate error. I'll fix that I guess.

@bbrk24
Copy link
Contributor Author

bbrk24 commented Mar 25, 2025

As stupid as this looks:

@available(iOS 14, macCatalyst 14, tvOS 14, *)
@available(tvOS, unavailable)

It failed to compile if I removed tvOS 14 from the former annotation.

Edit: posted to the forums https://forums.swift.org/t/contradictory-available-s-are-required/78831

@bbrk24 bbrk24 marked this pull request as ready for review March 26, 2025 00:04
Copy link
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! 🙏 Very useful

@stackotter stackotter merged commit 5b6a37f into stackotter:main Mar 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants