More tap gestures #117
Merged
More tap gestures #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mac & Linux are failing because GTK3. But why is Windows succeeding |
|
The Windows CI doesn't build WinUIBackend at the moment due to some annoying Swift on Windows issues. We can't use anything newer than Swift 5.10 cause of some weird issue where SwiftPM fails to compile the manifest due to missing CPP headers, but swift-winui requires Swift 6.0 |
Gtk3 and WinUI still only actually support .primary, but at least now they'll compile.
stackotter
approved these changes
Mar 17, 2025
stackotter
requested changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements right-click and long-press. Currently not implemented in Gtk3 or WinUI. I'm also not sold on the argument label because
onTapGesture(gesture:) {}looks a little odd.