Use a set for the list to avoid duplicates #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was being silly and didn't just appended blindly to a single slice which resulted in duplicates. Using a set seems like the cleanest option. On the API boundary, a plain slice is returned (I don't like returning 3rd party types from a public API..). There's also a new function to list all actions in a directory what I think the majority of users would like (except when parsing patches).
|
Have you tested this? I'm impressed the set works with a structure since it's a non-hashable object in golang |
Yes: vs: they seem to be the same..
The type only needs to be comparable according to the docs |
|
Hmm, not related to this patch per se I guess, but I think we have a bug somewhere. One of the uses says: but the corresponding list says: |
JAORMX
approved these changes
Nov 21, 2023
Remind me tomorrow, let's figure it out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was being silly and did just appended blindly to a single slice which resulted in duplicates. Using a set seems like the cleanest option. On the API boundary, a plain slice is returned (I don't like returning 3rd party types from a public API..). There's also a new function to list all actions in a directory what I think the majority of users would like (except when parsing patches).