Skip to content

Restore Claude release session reports - #1314

Merged
danbarr merged 2 commits into
mainfrom
restore-release-session-comments
Nov 4, 2026
Merged

danbarr merged 2 commits into
mainfrom
restore-release-session-comments

Conversation

@danbarr

@danbarr danbarr commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Release docs runs dispatched from trusted main no longer get Claude's automatic PR comments, leaving reviewers with only start/completion notices. Publish the generation and editorial sessions' final responses as separate PR comments, with the session status and workflow link.

Extract only the top-level final result, excluding instructions, tool output, and intermediate narration. Redact the pinned action's known GitHub, Anthropic, AWS, Slack, and JWT credential formats before truncation or publication. Publish generation's response before editorial overwrites the execution file, then clear it to prevent a failed editorial session from reusing generation's output. Missing or malformed output produces an explicit unavailable notice, and oversized responses are truncated with a run link. Reporting failures do not block documentation generation.

Load the reporter from the workflow's trusted revision and add regression tests to PR CI. Existing PRs are not backfilled.

Type of change

  • Bug fix

Related issues/PRs

Validation

  • Production site build passes.
  • All 27 release workflow, PR body, and session report tests pass, including mocked comment publication, transcript exclusion, malformed/missing output, credential redaction in the actual API request, truncation across a credential, and report ordering.
  • Prettier, ESLint, git diff --check, and Zizmor pass.
  • Actionlint reports the pre-existing $/.github/actions/setup syntax as unsupported; that line is unchanged.

Copilot AI balanced review requested due to automatic review settings November 4, 2026 17:42
@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs-website Ready Ready Preview Nov 4, 2026 5:53pm UTC

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The report script can publish credentials from Claude’s final explanation verbatim to PRs, bypassing secret redaction, and needs sanitization before truncation plus a mocked-publication regression test.

1 open issue
What changed in this PR

Restores Claude session reports on release-documentation PRs after the move to trusted dispatch runs, giving reviewers separate generation and editorial summaries.

Changes:

  • Adds final-response extraction, session status, workflow links, unavailable notices, and truncation.
  • Loads the reporter from the trusted workflow revision and publishes each session before its output is cleared or overwritten.
  • Adds regression tests and includes them in PR CI.
File Description
scripts/​upstream-release/​post-session-report.test.mjs Tests extraction, publication, fallbacks, truncation, and workflow ordering.
scripts/​upstream-release/​post-session-report.mjs Renders and publishes final session responses as PR comments.
.github/​workflows/​upstream-release-docs.yml Prepares the trusted reporter, posts session reports, and clears shared output.
.github/​workflows/​_static-checks.yaml Runs session-report regression tests in CI.

Review effort: Balanced

@danbarr
danbarr merged commit fe2dac5 into main Nov 4, 2026
7 checks passed
@danbarr
danbarr deleted the restore-release-session-comments branch November 4, 2026 20:51

This branch was successfully deployed

1 active deployment
Preview — d28c1a36 Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants