Repository navigation
Fix screenshot summary publication - #1289
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The privileged reusable-workflow handoff requires post-merge GitHub Actions validation to confirm trusted revision selection, inherited permissions, and PR-description updates for both commit-producing and no-op snapshot runs.
No open issues 🎉
What changed in this PR
This PR fixes screenshot-summary publication after /update-snapshots and keeps visual failure details available when the full Playwright report exceeds the download limit, as encountered in #1288.
Changes:
- Call the trusted summary workflow directly after baseline publication, even when no new commit is created.
- Skip PR description updates when the head commit or PR state has changed.
- Upload and consume compact failure details while preserving archive validation and the full-report fallback.
| File | Description |
|---|---|
scripts/update-pr-screenshot-summary.test.mjs |
Tests summary replacement and skipping advanced or closed PRs. |
scripts/update-pr-screenshot-summary.mjs |
Checks the current PR head and state before updating its description. |
.github/workflows/update-visual-baselines.yaml |
Exposes the published head SHA and directly calls the summary workflow. |
.github/workflows/pr-screenshot-summary.yaml |
Supports direct calls and prefers compact failure artifacts. |
.github/workflows/_visual-regression.yaml |
Uploads failure details separately from the full report. |
.github/workflows/_static-checks.yaml |
Runs the screenshot-summary updater tests in CI. |
.github/scripts/update_visual_failure_comment.py |
Accepts compact artifact paths alongside full-report paths. |
.github/scripts/test_update_visual_failure_comment.py |
Tests compact detail parsing and duplicate removal. |
Review effort: Balanced
danbarr
enabled auto-merge (squash)
October 28, 2026 20:30
jhrozek
approved these changes
Oct 29, 2026
2 of 4 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After
/update-snapshotspushes a bot commit, the follow-up screenshot-summary workflow may never start, leaving the PR description without the changed screenshots. Call the trusted summary workflow directly after baseline publication, including when regeneration produces no new commit, and skip description updates if the PR head or state has changed.Upload a separate artifact containing only Playwright failure details so the failure-comment table remains available when the full report exceeds the download limit. The report from #1288 is 52 MB; its failure details are only 20 KB. Preserve the existing archive validation and the full-report fallback for older runs.
Validation: all 30 Python and Node helper tests pass, along with focused Prettier and ESLint checks,
git diff --check, and the offline zizmor scan. Workflow syntax checks pass after normalizing the existing$/self-repository syntax for the older local actionlint version. Replayed #1288's actual failure details through the parser and confirmed the expected summary table. The production site build passes. The direct GitHub workflow handoff requires verification after merge because/update-snapshotsloads its workflow frommain.Type of change
Related issues/PRs
Submitter checklist
Content and formatting
Reviewer checklist
Content