This repository was archived by the owner on Nov 11, 2024. It is now read-only.
feat: adds waiting functionality #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopalet
reviewed
Nov 5, 2024
src/stackit/core/wait.py
Outdated
| class WaitConfig: | ||
| sleep_before_wait: int = 0 | ||
| throttle: int = 5 | ||
| timeout: int = 30 |
There was a problem hiding this comment.
Is the throttle in seconds and the timeout in minutes? Feels a bit strange
There was a problem hiding this comment.
And maybe could we have some small description for each field?
There was a problem hiding this comment.
Is the throttle in seconds and the timeout in minutes? Feels a bit strange
Yes. That is the same as the Go SDK
There was a problem hiding this comment.
In the Go SDK the fields are of type time.Duration instead of int. Then the user can pass them e.g. either as 5 * time.Seconds or 1 * time.Minute
There was a problem hiding this comment.
Ah ok, I see.
In that case this should be changes here and everything should be in seconds.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.