Skip to content

Conversation

h3adex
Copy link
Contributor

@h3adex h3adex commented Sep 22, 2025

Description

Adds functionality to list STACKIT public IP ranges.

The -o pretty flag does not render the output as a table, as this format wouldn't be useful. Instead, it joins all IP ranges with commas. This is helpful if you need to send the IP ranges to a customer or colleague.

E.g.
Screenshot 2025-09-22 at 10 16 19

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@h3adex h3adex requested a review from a team as a code owner September 22, 2025 08:14
@h3adex h3adex force-pushed the feat/list-stackit-ip-ranges branch 3 times, most recently from c9f99b7 to 10126de Compare September 22, 2025 08:19
@rubenhoenle
Copy link
Member

E.g. Screenshot 2025-09-22 at 10 16 19

Could we have this output with line breaks please?

This makes sense for users which want to work with tools like grep or e.g. fzf.

For reference, I personally love to work with CLIs like that: stackit public-ip ip-ranges list | fzf
And I think I'm not the only one 😄

@h3adex h3adex force-pushed the feat/list-stackit-ip-ranges branch from 10126de to 7eea142 Compare September 25, 2025 12:38
@h3adex
Copy link
Contributor Author

h3adex commented Sep 25, 2025

E.g. Screenshot 2025-09-22 at 10 16 19

Could we have this output with line breaks please?

This makes sense for users which want to work with tools like grep or e.g. fzf.

For reference, I personally love to work with CLIs like that: stackit public-ip ip-ranges list | fzf And I think I'm not the only one 😄

Very nice idea. Adjusted this PR and added this to the examples

@h3adex h3adex force-pushed the feat/list-stackit-ip-ranges branch from 7eea142 to c382cf8 Compare September 25, 2025 12:40
@h3adex
Copy link
Contributor Author

h3adex commented Sep 25, 2025

Sorry! Accidentally amended the changes.

@Benjosh95 Benjosh95 added the needs-work PR needs work from author. label Sep 26, 2025
@h3adex h3adex force-pushed the feat/list-stackit-ip-ranges branch 2 times, most recently from 1828f0b to a548ac8 Compare September 26, 2025 09:24
@h3adex
Copy link
Contributor Author

h3adex commented Sep 26, 2025

@Benjosh95 nice catches! Just rebased my pr and added your suggested changes

@h3adex h3adex requested a review from Benjosh95 September 26, 2025 09:27
@h3adex h3adex force-pushed the feat/list-stackit-ip-ranges branch 2 times, most recently from 741daf8 to c5c7637 Compare September 26, 2025 10:58
@Benjosh95 Benjosh95 force-pushed the feat/list-stackit-ip-ranges branch from a4b8381 to 3273588 Compare September 29, 2025 11:43
Benjosh95
Benjosh95 previously approved these changes Sep 29, 2025
rubenhoenle
rubenhoenle previously approved these changes Sep 29, 2025
@Benjosh95 Benjosh95 removed the needs-work PR needs work from author. label Sep 29, 2025
@Benjosh95 Benjosh95 force-pushed the feat/list-stackit-ip-ranges branch from 2b20d3d to bc9f629 Compare October 2, 2025 08:36
@Benjosh95 Benjosh95 merged commit 14481e4 into stackitcloud:main Oct 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants