Limit number of logs collected #7
Conversation
jovial
commented
Mar 12, 2025
•
jovial
commented
- Adds the ability to set the logcount via query parameter or config option. Elasticsearch is better for long term storage.
- Changes the default for log collection to false
- I think this is a better default as collection is very slow. I'm also no convinced it was working before either.
- Changed approach to using context parameter to make it easier to add extra query parameters in the future i.e we do not have to add a extra parameters to each function each time we want to add a new variable.
- Made config options specific to groups. We could add the global option back if necessary.
This query is extremely slow, so limit to 10 logs. Elasticsearch is better for long term storage.
|
@jovial suggested extending this to make the number of logs collected configurable via a scrape parameter. Marking as draft. |
I did implement this, but it 2025/03/17 09:01:55 error error getting log entries from log service Manager=iDRAC.Embedded.1 app=redfish_exporter collector=ManagerCollector error=failed to retrieve some items: [{"link":"/redfish/v1/Managers/iDRAC.Embedded.1/LogServices/FaultList/Entries?$top=10","error":"501: {\n "error": {\n "code": "Base.1.0.GeneralError",\n "message": "A general error has occurred. See ExtendedInfo for more information.",\n "@Message.ExtendedInfo": [\n {\n "@odata.type" : "#Message.v1_0_0.Message",\n "MessageId": "Base.1.0.InternalError",\n "Message": "not supported, Query parameter top not supported"\n }\n some log services don't support the query parameter: |
|
Split out here: #8. |
jovial
changed the title
| targetLoggerCtx.WithError(err).Error("error parsing collectlogs query parameter as a boolean") | ||
| return | ||
| } | ||
| collectionCtx, err := common.NewCollectionContext(r, target, hostConfig, targetLoggerCtx) |
There was a problem hiding this comment.
I like the addition of the context. From a quick glance, it now means that the redfish session is long lived? I.e. persists across scrapes. In that case, we need to handle re-authentication if the session expires / is deleted etc, or have I missed something?
