Fix error with long messages breaking for everyone #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sd109
previously requested changes
Apr 7, 2025
There was a problem hiding this comment.
Having looked more closely at the changes I made to the app.py script while upgrading to Gradio 5, I think the correct fix here is actually to replace the else with an elif len(history) > 0 clause here.
Could you give that a try and see if it handles long message errors better without us having to add extra error handling based on the message text (which is fragile since it'll break if vLLM ever change their error message format)
Alex-Welsh
force-pushed
the
fix-long-messages
branch
from
fc9e39e to
940bbd1
Compare
|
Untested, will revert draft soon |
Alex-Welsh
force-pushed
the
fix-long-messages
branch
from
940bbd1 to
f9c7203
Compare
|
Confirmed, it fixes the issue |
sd109
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error went like this:
User submits long message, backend returns BadRequestError,
INCLUDE_SYSTEM_PROMPTgets flipped, chat history breaks for everyone.These changes catch the error properly and tell the user to refresh the page.