Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SSSD and optionally LDAP #438

Merged
merged 27 commits into from
Jan 9, 2025
Merged

Support SSSD and optionally LDAP #438

merged 27 commits into from
Jan 9, 2025

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Sep 13, 2024 •
edited
Loading

Adds support for configuring sssd and sshd.

Requires the environment to provide an sssd.conf template.

Can be used to configure Active Directory integration via LDAP, as described here.

Includes sssd and sssd-ldap packages in the StackHPC fatimage.

@sjpb
Copy link
Collaborator Author

sjpb commented Sep 13, 2024

build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/10855441852

@sjpb
Copy link
Collaborator Author

sjpb commented Sep 17, 2024

build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/10899945823

@sjpb
Copy link
Collaborator Author

sjpb commented Sep 18, 2024

build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/10917560172

@sjpb
Copy link
Collaborator Author

sjpb commented Sep 20, 2024

build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/10960288558

@sjpb sjpb marked this pull request as ready for review September 20, 2024 13:36
@sjpb sjpb requested a review from a team as a code owner September 20, 2024 13:36
@sjpb sjpb requested a review from jovial September 20, 2024 13:36
sd109
sd109 previously approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@sd109 sd109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than possibly missing a default SSHD group definition.

@sjpb
Copy link
Collaborator Author

sjpb commented Oct 30, 2024

Build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/11590701984

@priteau
Copy link
Member

priteau commented Dec 19, 2024

@sjpb Any chance this could be merged?

@sjpb
Copy link
Collaborator Author

sjpb commented Jan 9, 2025 •
edited
Loading

Image build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/12692223260

cancelled CI pending above

wtripp180901
wtripp180901 previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@wtripp180901 wtripp180901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jovial
jovial previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@jovial jovial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sjpb @jovial
sssd review comments
a3b7303 
Co-authored-by: Will Szumski <[email protected]>
@sjpb sjpb dismissed stale reviews from jovial and wtripp180901 via a3b7303 January 9, 2025 20:25
@sjpb sjpb merged commit 2903223 into main Jan 9, 2025
3 of 6 checks passed
@sjpb sjpb deleted the feat/sssd-ldap-v2 branch January 9, 2025 20:26
@sjpb sjpb mentioned this pull request Jan 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jovial jovial jovial left review comments

@sd109 sd109 sd109 left review comments

@wtripp180901 wtripp180901 wtripp180901 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sjpb @priteau @jovial @sd109 @wtripp180901