Wallet indicators #2002
Draft
Wallet indicators #2002
+59
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekzyis
commented
Mar 20, 2025
| const wallets = useConfiguredWallets() | ||
|
|
||
| const profileIndicator = !me.bioId | ||
| const walletIndicator = wallets.length === 0 |
There was a problem hiding this comment.
If one removes all wallets, the indicator will show up again. Not sure if that's good.
There was a problem hiding this comment.
Could be an encouragement to attach back a wallet ⚡️
do you see it getting old over time?
There was a problem hiding this comment.
do you see it getting old over time?
Yes. Some people don't want to attach a wallet so they should have the option to remove this indicator / keep it removed in some way.
ekzyis
commented
Mar 20, 2025
| const wallets = useConfiguredWallets() | ||
|
|
||
| const profileIndicator = me && !me.bioId | ||
| const walletIndicator = wallets.length === 0 |
ekzyis
force-pushed
the
wallet-indicator
branch
from
50280dd to
c7539b9
Compare
ekzyis
force-pushed
the
wallet-indicator
branch
from
c7539b9 to
bccfcb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show an indicator if no wallet has been setup yet like we do for bios.
TODO:
Examples:
attachbuttons on wallet page with same colorattach walletbutton with some text below explaining why one should do that. it will simply reveal the wallet page when clicked.Screenshots
Checklist
Are your changes backwards compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
tbd
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
tbd
Did you introduce any new environment variables? If so, call them out explicitly here:
no