-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add territory status and territory revenue notifications #1856
Open
Soxasora
wants to merge
11
commits into
stackernews:master
Choose a base branch
from
Soxasora:more_push_notifications
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
254b27e
to
5145c7f
Compare
7837559
to
1dd1bcc
Compare
1dd1bcc
to
6e9be5b
Compare
Added myself as a reviewer so I don't forget about this but I will probably review this when I have less more important things to do. Just FYI! I think the changes in this PR won't conflict with other stuff much so you won't need to merge/rebase a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #1845
It adds the following missing push notifications:
-- on every
territoryStatusUpdate
and successful auto-renewal after failure, send a notification with the new status-- when
territoryRevenue
gets executed, send a notification with values calculated in the last hour- Referral rewards-- add support for Forever Referral and One Day Referral tonotifyEarner
Screenshots
Additional Context
Unsure:
Not available:
Checklist
Are your changes backwards compatible? Please answer below:
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
6, notification gets sent but didn't test thoroughly
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
Did you introduce any new environment variables? If so, call them out explicitly here:
Progress
- [x] ReferralReward- needs testing