Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe unarchiver to unarchived territory #1839

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

Soxasora
Copy link
Member

Description

Fixes #1790
Simple transaction to subscribe the user to the territory they unarchived.

Screenshots

n/a

Additional Context

n/a

Checklist

Are your changes backwards compatible? Please answer below:
Yes, just adds a transaction

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7, unarchived a territory and got subscribed to it

For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a

Did you introduce any new environment variables? If so, call them out explicitly here:
No

@Soxasora Soxasora changed the title enhance: subscribe unarchiver to unarchived territory Subscribe unarchiver to unarchived territory Jan 22, 2025
@Soxasora Soxasora added bug enhancement improvements to existing features labels Jan 22, 2025
@huumn
Copy link
Member

huumn commented Jan 23, 2025

This had an issue such that if the unarchiver were already subscribed to the territory, the unique constraint on subSubscription would prevent unarchiving, so I switched it to upsert. I took the liberty to also fix #1517

@huumn huumn merged commit 47faef8 into stackernews:master Jan 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unarchiving someone else's territory doesn't subscribe the new owner
2 participants