-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add editPageLink
in demo
#343
Conversation
Run & review this pull request in StackBlitz Codeflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Charan167!
While this already works really nicely, we can reduce the amount of code by defining it only in top-level metadata, here:
tutorialkit/docs/demo/src/content/tutorial/meta.md
Lines 1 to 6 in c8ce182
--- | |
type: tutorial | |
mainCommand: ['npm run dev', 'Starting http server'] | |
prepareCommands: | |
- ['npm install', 'Installing dependencies'] | |
--- |
So looking at your code, I think something like this could work there:
---
editPageLink: https://github.com/stackblitz/tutorialkit/blob/main/docs/demo/src/content/tutorial/${path}?plain=1
---
The ${path}
here is dynamic parameter that TutorialKit will automatically apply there per-lesson.
@AriPerkkio Forgive my noobness 😅. Please let me know if any more changes are needed. Also, feel free to let me know if you need help with any other issues—I'd be more than happy to work on them. |
docs/demo/src/content/tutorial/1-forms-css/3-fieldset/1-fieldset-element/content.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @Charan167!
Also, feel free to let me know if you need help with any other issues—I'd be more than happy to work on them.
Awesome! Maybe these issues could be good next?
editPageLink
in demo
Recording.2024-09-21.193033_compressed.mp4