-
-
Notifications
You must be signed in to change notification settings - Fork 3
fix: idempotent helm installations for demos/stacks and ignoring of existing jobs #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Would you mind updating the PR description and adding example output for the Job immutable fields? I was just curious what to expect.
Description
Implementation for #312 and #333
Current procedure to upgrade a demo:
Example output of failed Job updates due to immutability:
Problem encountered during development when running
helm upgrade --install
onopensearch-dashboards
Thrown for
opensearch-dashboards
Helm Chart, because of opensearch-project/helm-charts#655Should be working due to setting
ChartSpec.Force = true
inrust/helm-sys/go-helm-wrapper/main.go
but does not.Update/Solution: Due to changes in Helm 3 and how the
--force
flag works (helm/helm#7082 (comment)), @NickLarsenNZ and me decided to switch from thehelm upgrade --install
to the strategy of uninstalling the old Helm Chart and installing the new one instead for an upgrade.Definition of Done Checklist