Skip to content

feat(stackable-versioned): Add from_name parameter validation #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Sep 16, 2024

Part of stackabletech/issues#507

This PR adds validation to the from_name parameter of the changed() action. It is now prohibited to use field / variant names which include the deprecation prefix.

Reviewer

Preview Give feedback

@Techassi Techassi self-assigned this Sep 16, 2024
@Techassi Techassi marked this pull request as ready for review September 16, 2024 15:27
@NickLarsenNZ NickLarsenNZ self-requested a review September 16, 2024 16:25
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 1487096 Sep 17, 2024
10 checks passed
@Techassi Techassi deleted the feat/crd-versioning-changed-validation branch September 17, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants