Enhance health check endpoint to verify database connectivity #230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
/_mgmt/ping
endpoint to check if pgstac is ready #229Description:
Overview
This PR enhances the
/_mgmt/ping
health check endpoint to actually verify database connectivity before returning a positive response. The current implementation always returns{"message": "PONG"}
regardless of whether the database is actually accessible, which can lead to misleading health checks in production environments.Changes Made
PgStacApi
class instac_fastapi/pgstac/app.py
that extends the baseStacApi
classadd_health_check
method to implement database connectivity checkspgstac.migrations
tabletests/resources/test_mgmt.py
to verify the new response formatImplementation Details
The enhanced endpoint now:
{"message": "PONG", "database": "OK"}
with status 200 when the database is healthyBenefits
Testing
The implementation can be tested by:
PR Checklist:
pre-commit
hooks pass locallymake test
)make docs
)