Add MLM extension #1542
Open
Add MLM extension #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, percentage, count
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1542 +/- ##
==========================================
+ Coverage 91.62% 92.34% +0.72%
==========================================
Files 54 55 +1
Lines 7578 8349 +771
Branches 923 959 +36
==========================================
+ Hits 6943 7710 +767
- Misses 451 453 +2
- Partials 184 186 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gadomski
requested changes
Apr 7, 2025
Comment on lines
+9
to
+11
|
|
||
| ### Fixed | ||
| - fixed missing parameter "title" in pystac.extensions.classification.Classification ([#1539](https://github.com/stac-utils/pystac/pull/1539)) |
There was a problem hiding this comment.
Suggested change
| ### Fixed | |
| - fixed missing parameter "title" in pystac.extensions.classification.Classification ([#1539](https://github.com/stac-utils/pystac/pull/1539)) |
Comment on lines
+231
to
+234
| @property | ||
| def mlm(self) -> MLMExtension[Item]: | ||
| return MLMExtension.ext(self.stac_object) | ||
|
|
There was a problem hiding this comment.
Looks like this needs to be added to CollectionExt too.
Comment on lines
+115
to
+127
| REGRESSION = ("regression",) | ||
| CLASSIFICATION = ("classification",) | ||
| SCENE_CLASSIFICATION = ("scene-classification",) | ||
| DETECTION = ("detection",) | ||
| OBJECT_DETECTION = ("object-detection",) | ||
| SEGMENTATION = ("segmentation",) | ||
| SEMANTIC_SEGMENTATION = ("semantic-segmentation",) | ||
| INSTANCE_SEGMENTATION = ("instance-segmentation",) | ||
| PANOPTIC_SEGMENTATION = ("panoptic-segmentation",) | ||
| SIMILARITy_SEARCH = ("similarity-search",) | ||
| GENERATIVE = ("generative",) | ||
| IAMGE_CAPTIONING = ("image-captioning",) | ||
| SUPER_RESOLUTION = "super-resolution" |
There was a problem hiding this comment.
Is there a reason that some of these are one-tuples and others are strings?
| name: Name of the band referring to an extended band definition | ||
| format: The type of expression that is specified in the expression property | ||
| expression: An expression compliant with the format specified. | ||
| The cxpression can be applied to any data type and depends on the |
There was a problem hiding this comment.
Suggested change
| The cxpression can be applied to any data type and depends on the | |
| The expression can be applied to any data type and depends on the |
Comment on lines
+470
to
+474
| type: The type of ValueScaling operation for which required proreties are | ||
| to be retrieved | ||
|
|
||
| Returns: | ||
| list[str]: names of proreties required for the given ``type`` |
There was a problem hiding this comment.
Suggested change
| type: The type of ValueScaling operation for which required proreties are | |
| to be retrieved | |
| Returns: | |
| list[str]: names of proreties required for the given ``type`` | |
| type: The type of ValueScaling operation for which required properties are | |
| to be retrieved | |
| Returns: | |
| list[str]: names of properties required for the given ``type`` |
| cls, type: ValueScalingType, props: dict[str, Any] | ||
| ) -> None: | ||
| """ | ||
| Validate whether given properties satisfy the requiremts set by the ValueScaling |
There was a problem hiding this comment.
Suggested change
| Validate whether given properties satisfy the requiremts set by the ValueScaling | |
| Validate whether given properties satisfy the requirements set by the ValueScaling |
| MLMExtension[T]: The extended object | ||
|
|
||
| Raises: | ||
| TypeError: When a :class:`pystac.Asset` object is apssed as the |
There was a problem hiding this comment.
Suggested change
| TypeError: When a :class:`pystac.Asset` object is apssed as the | |
| TypeError: When a :class:`pystac.Asset` object is passed as the |
| @property | ||
| def accelerator_constrained(self) -> bool | None: | ||
| """ | ||
| Get or set the accelerator_constrianed property |
There was a problem hiding this comment.
Suggested change
| Get or set the accelerator_constrianed property | |
| Get or set the accelerator_constrained property |
| """ | ||
| Get or set this asset's compile_method property | ||
| """ | ||
| return self.properties.get(COMPILE_MDTHOD_ASSET_PROP) |
There was a problem hiding this comment.
Suggested change
| return self.properties.get(COMPILE_MDTHOD_ASSET_PROP) | |
| return self.properties.get(COMPILE_METHOD_ASSET_PROP) |
| """ | ||
| Get or set this asset's entrypoint property asdfasdf | ||
| """ | ||
| return self.properties.get(ENTRYPOITN_ASSET_PROP) |
There was a problem hiding this comment.
Suggested change
| return self.properties.get(ENTRYPOITN_ASSET_PROP) | |
| return self.properties.get(ENTRYPOINT_ASSET_PROP) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Adds the STAC:MLM extension: https://github.com/stac-extensions/mlm
PR Checklist:
pre-commit run --all-files)pytest)