Skip to content

fix: link to repo root instead of 404ing /stargazers page #8756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
katspaugh wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

fix: link to repo root instead of 404ing /stargazers page #8756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/renderer/src/components/Landing.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ type ShortcutItem = {
action: string
}

const ORCA_STARGAZERS_URL = 'https://github.com/stablyai/orca/stargazers'
// Do not deep-link to /stargazers: GitHub 404s that page for users without repo write access.
const ORCA_GITHUB_URL = 'https://github.com/stablyai/orca'

type StarState = 'loading' | 'starred' | 'not-starred' | 'web-fallback' | 'hidden'

Expand Down Expand Up @@ -72,7 +73,7 @@ function GitHubStarButton({ hasRepos }: { hasRepos: boolean }): React.JSX.Elemen
return
}
if (state === 'web-fallback') {
await window.api.shell.openUrl(ORCA_STARGAZERS_URL)
await window.api.shell.openUrl(ORCA_GITHUB_URL)
return
}
if (state !== 'not-starred') {
Expand Down
5 changes: 3 additions & 2 deletions src/renderer/src/components/settings/GeneralSupportSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ import { SearchableSetting } from './SearchableSetting'
import { SettingsSubsectionHeader } from './SettingsFormControls'
import { translate } from '@/i18n/i18n'

const ORCA_STARGAZERS_URL = 'https://github.com/stablyai/orca/stargazers'
// Do not deep-link to /stargazers: GitHub 404s that page for users without repo write access.
const ORCA_GITHUB_URL = 'https://github.com/stablyai/orca'

type SupportState =
| 'loading'
Expand Down Expand Up @@ -58,7 +59,7 @@ export function GeneralSupportSection({
const handleStarClick = async (): Promise<void> => {
if (starState === 'web-fallback') {
setStarState('opening-github')
await window.api.shell.openUrl(ORCA_STARGAZERS_URL)
await window.api.shell.openUrl(ORCA_GITHUB_URL)
if (mountedRef.current) {
setStarState('web-fallback')
}
Expand Down
Loading