feat: add --no-unfurl to message sends - #133
Open
jeiea wants to merge 1 commit into
Open
Conversation
[Background] Slack unfurls text and media links by default, while the CLI exposed no per-message preview control. https://docs.slack.dev/messaging/unfurling-links-in-messages/ Native Slack drafts and message edits do not expose the same send-time controls. File uploads reject the flag because their API accepts no unfurl fields. [Verification] - [x] `mise x bun@1.3.9 -- bun test test/message-send.test.ts test/safe-mode.test.ts test/help-contracts.test.ts` - 74 tests passed - [x] `mise x bun@1.3.9 -- bun test` - 351 tests passed - [x] `mise x bun@1.3.9 -- bun run typecheck` - passed AI-assistant: Claude Fable 5, GPT-5.6-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background 📝
unfurl_linksandunfurl_mediato be disabled to suppress previews.Changes 🛠️
--no-unfurlto immediate and scheduledmessage sendcalls.--no-unfurlthroughmessage composeand safe-mode redirects.--no-unfurlwith file attachments because Slack's upload API accepts no unfurl fields.Comments 🤔
Test method 🔍
mise x bun@1.3.9 -- bun test test/message-send.test.ts test/safe-mode.test.ts test/help-contracts.test.ts- 74 tests passedmise x bun@1.3.9 -- bun test- 351 tests passed