Takeover #74: workflow --field submission (needs live smoke test)#123
Open
nwparker wants to merge 2 commits into
Open
Takeover #74: workflow --field submission (needs live smoke test)#123nwparker wants to merge 2 commits into
nwparker wants to merge 2 commits into
Conversation
Add `--field Title=value` support to `workflow run`, enabling form submission through a short-lived RTM WebSocket that captures view_opened events and submits via views.submit. New modules: - rtm-websocket: low-level Bun-compatible WebSocket over node:https - workflow-submit: orchestrates trip → capture → submit flow
# Conflicts: # skills/agent-slack/SKILL.md # skills/agent-slack/references/commands.md
3 tasks
Contributor
Author
|
Two specifics to check during the live smoke test (from verification of the unit coverage):
Everything else is green offline: 337 tests / 0 fail, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takeover of #74 (@shhac) —
workflow run --fieldform submission over RTM WebSocket. Docs-only conflicts resolved (re-applied--fieldnote to the restructuredSKILL.md, dropped the deletedcommands.md); source (+722) merged cleanly. Branchtakeover/pr-74.Verified (offline)
build:npm+node --checkOKworkflow run --helpshows--field <title=value>(repeatable)test/rtm-websocket.test.ts(RFC-6455 frame parse/mask/fragments) andtest/workflow-submit.test.ts(field-title validation vs schema + block/action mapping)The end-to-end path (a real
view_openedover a livewss://with browser auth against an actual workflow form) can't be exercised offline. Please run one realworkflow run <trigger> --field "…=…"before merging. Everything else is green.Made with Orca 🐋