Takeover #108: Chrome import for HttpOnly cookie (needs live smoke test)#122
Open
nwparker wants to merge 3 commits into
Open
Takeover #108: Chrome import for HttpOnly cookie (needs live smoke test)#122nwparker wants to merge 3 commits into
nwparker wants to merge 3 commits into
Conversation
This was referenced Jul 18, 2026
Contributor
Author
|
Note for the merge decision: on close inspection the fallback is a faithful port of the proven |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takeover of #108 (@sudhanshug16) — Chrome import fallback for the HttpOnly Slack
dcookie. Rebased cleanly ontomain, branchtakeover/pr-108.Addresses the Chrome side of #13.
Verified (offline)
build:npm+node --checkOKmainadded test files mockingimportChromesynchronously; made those mocksasync(the PR makesimportChromeasync).src/auth/brave.tsimporter.The crypto/cookie-DB fallback can't be exercised offline without a logged-in Chrome that has an HttpOnly
dcookie. Please runagent-slack auth import-chromeonce against a real HttpOnly Chrome session before merging (the original author reports doing this successfully). Everything else is green.Made with Orca 🐋