fix(users): support W-prefixed Slack user IDs#114
Merged
Conversation
dwaxe
force-pushed
the
dwaxe/support-w-user-ids
branch
from
July 16, 2026 20:14
0212157 to
37f8c56
Compare
dwaxe
marked this pull request as ready for review
July 16, 2026 20:40
nwparker
approved these changes
Jul 18, 2026
nwparker
left a comment
nwparker
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the diff, ran the full test suite (248 pass), typecheck, lint, and format check locally — all clean. The consolidation of user-ID validation into src/slack/user-id.ts is the right call, and the loosened mention regex in user-cache still validates via isUserId before use. Docs/skill updates match the behavior.
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack treats
U- andW-prefixed user IDs equivalently, but agent-slack recognizesWIDs only in some read paths. They already work in referenced-user caching but fail in direct-message targets, user lookup and resolution, search filters, and reaction compaction. This change makes one semantic user-ID validator authoritative across those paths and aligns the installed help and bundled skill with the resulting behavior.Co-authored by GPT 5.6-Sol.