Andreas make-build changes #4
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabedini
force-pushed
the
andrea/make-build
branch
from
3256923 to
01e5a91
Compare
andreabedini
force-pushed
the
andrea/make-build
branch
10 times, most recently
from
eec3056 to
56151a3
Compare
andreabedini
force-pushed
the
andrea/make-build
branch
6 times, most recently
from
af0c49f to
dd0df21
Compare
The field "extra-libraries-static" is available only since version 3.8 of the Cabal specification.
Unused at least since August 2008 (9329cdb)
AC_PROG_CC already sets the necessary compiler flags to enable the latest language standard.
Checking the source code is appropriate for a linter, not for the configure script.
The boot script performs two tasks - it checks for the presence of boot packages - it runs autoreconf in each boot package The first task is not valuable enough and likely could be implemented within autoconf. The second task be implemented in a standardised way using the macro AC_CONFIG_SUBDIRS.
Checking LLVM version introduces complexity for not enough benefits. Trust the users and let them deal with the consequences.
There is little value in generating a C array from a Python list.
andreabedini
force-pushed
the
andrea/make-build
branch
from
2f3f6ff to
64db5c6
Compare
All of these are strings. show will add extra quotes. Thus leading to __GLASGOW_HASKELL__ being "<version>" (including the quotes, and any comparions will fail as we are comparing "XYZ" < ABC.
We need them for the custom setups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.